Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to make code thread friendly #5

Merged
1 commit merged into from
Aug 19, 2015

Conversation

Dr15Jones
Copy link

Made function static arrays just be stack arrays and changed static
bools to be std::atomic. This allows multiple threads to each
safely talk to their own copies of the objects without race conditions.

Made function static arrays just be stack arrays and changed static
bools to be std::atomic<bool>. This allows multiple threads to each
safely talk to their own copies of the objects without race conditions.
@Dr15Jones
Copy link
Author

@smuzaffar @davidlange6 @lgray This should fix the recent fastjet related thread-safety problems found from Lindsey's running of helgrind.

@davidlange6
Copy link

@Degano

On Aug 17, 2015, at 11:07 PM, Chris Jones [email protected] wrote:

@smuzaffar @davidlange6 @lgray This should fix the recent fastjet related thread-safety problems found from Lindsey's running of helgrind.


Reply to this email directly or view it on GitHub.

ghost pushed a commit that referenced this pull request Aug 19, 2015
Changes to make code thread friendly
@ghost ghost merged commit f873eac into cms-externals:cms/v1.014 Aug 19, 2015
@ghost
Copy link

ghost commented Aug 19, 2015

@Dr15Jones @davidlange6 I've merged this change in 76X: cms-sw/cmsdist#1745

@lgray
Copy link

lgray commented Aug 19, 2015

@Dr15Jones once this is in a working IB I'll revert the change of
NjettinessAdder to edm::one back to edm::stream.

On Wed, Aug 19, 2015 at 10:17 AM, Alessandro Degano <
[email protected]> wrote:

@Dr15Jones https://github.com/Dr15Jones @davidlange6
https://github.com/davidlange6 I've merged this change in 76X:
cms-sw/cmsdist#1745 cms-sw/cmsdist#1745


Reply to this email directly or view it on GitHub
#5 (comment)
.

@Dr15Jones
Copy link
Author

Sounds good

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants