Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "cuda_cxx17.h" #519

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Remove "cuda_cxx17.h" #519

merged 1 commit into from
Jul 19, 2020

Conversation

fwyzard
Copy link

@fwyzard fwyzard commented Jul 18, 2020

Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.

@fwyzard
Remove "cuda_cxx17.h"
0bc3c22 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
@fwyzard fwyzard requested a review from makortel July 18, 2020 18:01
@fwyzard
Copy link
Author

fwyzard commented Jul 18, 2020 •
edited
Loading

Validation summary

Reference release CMSSW_11_2_0_pre2 at 92997c6
Development branch cms-patatrack/CMSSW_11_2_X_Patatrack at db29562
Testing PRs:

Validation plots

/RelValTTbar_14TeV/CMSSW_11_1_0_pre8-PU_111X_mcRun3_2021_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 11634.5
  • tracking validation plots and summary for workflow 11634.501
  • tracking validation plots and summary for workflow 11634.502

/RelValZMM_14/CMSSW_11_1_0_pre8-111X_mcRun3_2021_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 11634.5
  • tracking validation plots and summary for workflow 11634.501
  • tracking validation plots and summary for workflow 11634.502

/RelValZEE_14/CMSSW_11_1_0_pre8-111X_mcRun3_2021_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • tracking validation plots and summary for workflow 11634.5
  • tracking validation plots and summary for workflow 11634.501
  • tracking validation plots and summary for workflow 11634.502

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.885502.png
zoom-136.885502.png
scan-136.885522.png
zoom-136.885522.png

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_1_0_pre8-PU_111X_mcRun3_2021_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 11634.5
  • development release, workflow 11634.5
  • development release, workflow 11634.501
  • development release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 11634.511
  • development release, workflow 11634.512
    • ❌ step3.py: log
    • ❌ profile.py: log, profile and summary are missing, see the full log for more information
    • ⚠️ cuda-memcheck --tool initcheck did not run
    • ⚠️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
    • ⚠️ cuda-memcheck --tool synccheck did not run
  • development release, workflow 11634.521
  • development release, workflow 11634.522
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ❌ cuda-memcheck --tool initcheck (report, log) found 1020936 errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
  • development release, workflow 136.885502
  • development release, workflow 136.885512
  • development release, workflow 136.885522
  • testing release, workflow 11634.5
  • testing release, workflow 11634.501
  • testing release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 11634.511
  • testing release, workflow 11634.512
    • ❌ step3.py: log
    • ❌ profile.py: log, profile and summary are missing, see the full log for more information
    • ⚠️ cuda-memcheck --tool initcheck did not run
    • ⚠️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
    • ⚠️ cuda-memcheck --tool synccheck did not run
  • testing release, workflow 11634.521
  • testing release, workflow 11634.522
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ❌ cuda-memcheck --tool initcheck (report, log) found 957576 errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
  • testing release, workflow 136.885502
  • testing release, workflow 136.885512
  • testing release, workflow 136.885522

/RelValZMM_14/CMSSW_11_1_0_pre8-111X_mcRun3_2021_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 11634.5
  • development release, workflow 11634.5
  • development release, workflow 11634.501
  • development release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 11634.511
  • development release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
  • development release, workflow 11634.521
  • development release, workflow 11634.522
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ❌ cuda-memcheck --tool initcheck (report, log) found 47112 errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 136.885502
  • development release, workflow 136.885512
  • development release, workflow 136.885522
  • testing release, workflow 11634.5
  • testing release, workflow 11634.501
  • testing release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 11634.511
  • testing release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
  • testing release, workflow 11634.521
  • testing release, workflow 11634.522
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ❌ cuda-memcheck --tool initcheck (report, log) found 46400 errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
  • testing release, workflow 136.885502
  • testing release, workflow 136.885512
  • testing release, workflow 136.885522

/RelValZEE_14/CMSSW_11_1_0_pre8-111X_mcRun3_2021_realistic_v4-v1/GEN-SIM-DIGI-RAW

  • reference release, workflow 11634.5
  • development release, workflow 11634.5
  • development release, workflow 11634.501
  • development release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • development release, workflow 11634.511
  • development release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
  • development release, workflow 11634.521
  • development release, workflow 11634.522
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ❌ cuda-memcheck --tool initcheck (report, log) found 26472 errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
  • development release, workflow 136.885502
  • development release, workflow 136.885512
  • development release, workflow 136.885522
  • testing release, workflow 11634.5
  • testing release, workflow 11634.501
  • testing release, workflow 11634.502
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 11634.511
  • testing release, workflow 11634.512
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ✔️ cuda-memcheck --tool initcheck (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ❌ cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
  • testing release, workflow 11634.521
  • testing release, workflow 11634.522
    • ✔️ step3.py: log
    • ✔️ profile.py: log
    • ❌ cuda-memcheck --tool initcheck (report, log) found 26728 errors
    • ✔️ cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
    • ✔️ cuda-memcheck --tool synccheck (report, log) did not find any errors
  • testing release, workflow 136.885502
  • testing release, workflow 136.885512
  • testing release, workflow 136.885522

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/1d269c038dc8b6bbc65e2d63ad52af9c5a174b13/log .

@makortel
Copy link

I suppose this one https://github.com/cms-patatrack/cmssw/blob/CMSSW_11_2_X_Patatrack/HeterogeneousCore/CUDAUtilities/interface/MessageLogger.h could also be removed now.

@fwyzard
Copy link
Author

fwyzard commented Jul 19, 2020

I suppose this one https://github.com/cms-patatrack/cmssw/blob/CMSSW_11_2_X_Patatrack/HeterogeneousCore/CUDAUtilities/interface/MessageLogger.h could also be removed now.

Probably, though I'm still a bit hesitant to expose the whole framework to nvcc ...

@fwyzard fwyzard merged commit 2f93e3f into cms-patatrack:CMSSW_11_2_X_Patatrack Jul 19, 2020
fwyzard added a commit that referenced this pull request Jul 21, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
9156aad 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
@fwyzard fwyzard deleted the remove_cuda_cxx17 branch July 31, 2020 08:26
@fwyzard fwyzard mentioned this pull request Aug 10, 2020
Merged
fwyzard added a commit that referenced this pull request Oct 8, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
d6605b5 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
@fwyzard fwyzard mentioned this pull request Oct 8, 2020
Merged
fwyzard added a commit that referenced this pull request Oct 19, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
6f70763 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
fwyzard added a commit that referenced this pull request Oct 20, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
b73a792 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
fwyzard added a commit that referenced this pull request Oct 23, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
e5ec11b 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
fwyzard added a commit that referenced this pull request Nov 6, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
7da004f 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
fwyzard added a commit that referenced this pull request Nov 16, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
2fc82a1 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
fwyzard added a commit that referenced this pull request Nov 27, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
25ffc1f 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
fwyzard pushed a commit that referenced this pull request Dec 25, 2020
@cmsbuild @fwyzard
Remove "cuda_cxx17.h" (#519)
a9bcd0e 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
fwyzard pushed a commit that referenced this pull request Dec 29, 2020
@cmsbuild @fwyzard
Remove "cuda_cxx17.h" (#519)
ec6f640 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
bfa2c7f 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
fwyzard added a commit that referenced this pull request Dec 29, 2020
@fwyzard
Remove "cuda_cxx17.h" (#519)
52ea6f7 
Remove the C++ 17 compatibility functions now that CUDA 11.0 and later support C++ 17 natively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fwyzard @makortel