Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update root to include fix for TH1::clone leak." #1857

Merged
merged 1 commit into from
Sep 30, 2015

Conversation

smuzaffar
Copy link
Contributor

Reverts #1852

smuzaffar added a commit that referenced this pull request Sep 30, 2015
Revert "Update root to include fix for TH1::clone leak."
@smuzaffar smuzaffar merged commit 24e1445 into IB/CMSSW_7_4_X/root6 Sep 30, 2015
@davidlt
Copy link
Contributor

davidlt commented Sep 30, 2015

Why revert? If I recall, this is a critical and required memory leak fix.

@smuzaffar
Copy link
Contributor Author

74X IBs and 7.4.14 release failed
https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc6_amd64_gcc491/www/wed/7.4-wed-11/CMSSW_7_4_X_2015-09-30-1100

Traceback (most recent call last):
  File "/build/cmsbuild/jenkins-workarea/workspace/build-cache/cms.week0/w/tmp/BUILDROOT/83961e39f93f631edfab59d8d104c1a4/opt/cmssw/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2015-09-30-1100/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 186, in <module>
    errorCode,rootClassVersion,classChecksum = checkClass(name,info[XmlParser.classVersionIndex],info[XmlParser.versionsToChecksumIndex])
  File "/build/cmsbuild/jenkins-workarea/workspace/build-cache/cms.week0/w/tmp/BUILDROOT/83961e39f93f631edfab59d8d104c1a4/opt/cmssw/slc6_amd64_gcc491/cms/cmssw/CMSSW_7_4_X_2015-09-30-1100/src/FWCore/Utilities/scripts/edmCheckClassVersion", line 129, in checkClass
    raise RuntimeError("TClass::GetCheckSum: Failed to load dictionary for base class. See previous Error message")
RuntimeError: TClass::GetCheckSum: Failed to load dictionary for base class. See previous Error message

my guess is that it is due to this root update.

@davidlt
Copy link
Contributor

davidlt commented Sep 30, 2015

But the same ROOT is in CMSSW_7_6_X and it works fine. Also does this rever bubbles up to CMSSW_7_6_X via auto-crap-forward?

@smuzaffar
Copy link
Contributor Author

76X is using the tip of 6-02-00-branches while 74X is way behind that one.
Ah I see that beside the cms-sw/root#101 (memory leak fix) there is also cms-sw/root#95 from @Dr15Jones for thread efficiency changes got in to 74X. @davidlange6 , I guess we do not want cms-sw/root#95 to be part of 74X yet .....right?

@davidlange6
Copy link
Contributor

Its not a big problem if the thread efficiency changes were included - but if these are the two changes to root that went in, I’m sure its #95 that causes the checksum issues (and thus is a sign that we would need a different implementation to be compatible with the 74x root)

So, lets indeed go back to just the 74x root + cms-sw/root#95

On Oct 1, 2015, at 12:13 AM, Malik Shahzad Muzaffar [email protected] wrote:

76X is using the tip of 6-02-00-branches while 74X is way behind that one.
Ah I see that beside the cms-sw/root#101 (memory leak fix) there is also cms-sw/root#95 from @Dr15Jones for thread efficiency changes got in to 74X. @davidlange6 , I guess we do not want cms-sw/root#95 to be part of 74X yet .....right?


Reply to this email directly or view it on GitHub.

@smuzaffar smuzaffar deleted the revert-1852-rootleakfix_74XRoot6 branch March 9, 2016 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants