Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tkonline 80x #2193

Merged
merged 2 commits into from
Mar 16, 2016
Merged

Update tkonline 80x #2193

merged 2 commits into from
Mar 16, 2016

Conversation

smuzaffar
Copy link
Contributor

No description provided.

David Abdurachmanov added 2 commits March 16, 2016 20:42
@smuzaffar
tkonlinesw: bump to 4.0.0-1
8b8d091 
Signed-off-by: David Abdurachmanov <[email protected]>
(cherry picked from commit c5cdd88)
@smuzaffar
tkonlinesw: use unordered_map on Clang and ICC
480a57f 
This is needed to resolve compilation errors on Clang which reports GCC
4.2.1 compatibility.

Signed-off-by: David Abdurachmanov <[email protected]>
@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_8_0_X/stable.

@cmsbuild, @smuzaffar, @Degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/cmsdist-test-pr/132/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 480a57f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2193/132/summary.html

@smuzaffar
Copy link
Contributor Author

+externals

smuzaffar added a commit that referenced this pull request Mar 16, 2016
@smuzaffar
Merge pull request #2193 from smuzaffar/update-tkonline-80x
e817c78 
Update tkonline 80x
@smuzaffar smuzaffar merged commit e817c78 into cms-sw:IB/CMSSW_8_0_X/stable Mar 16, 2016
@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_8_0_X/stable IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @smuzaffar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
externals-approved fully-signed orp-pending tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smuzaffar @cmsbuild