Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit data-PhysicsTools-NanoAOD.spec #3431

Merged
merged 2 commits into from
Sep 20, 2017
Merged

initial commit data-PhysicsTools-NanoAOD.spec #3431

merged 2 commits into from
Sep 20, 2017

Conversation

mrodozov
Copy link
Contributor

initial commit for adding data-PhysicsTools-NanoAOD.spec file and a reference for it in cmsswdata.spec

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mrodozov for branch IB/CMSSW_9_4_X/gcc630.

@cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

smuzaffar
smuzaffar reviewed Sep 19, 2017
View reviewed changes
cmsswdata.spec Outdated
@@ -46,6 +46,7 @@ Requires: data-SimTracker-SiStripDigitizer
Requires: data-CalibCalorimetry-EcalTrivialCondModules
Requires: data-DataFormats-PatCandidates
Requires: data-SimTransport-HectorProducer
Requires: data-PhysicsTools-NanoAOD.spec
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrodozov , please remove the .spec extension here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar updated

@mrodozov mrodozov force-pushed the init-PhysicsTools-NanoAOD-spec branch from 34da135 to 277cbb7 Compare September 19, 2017 16:07
@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23094/console

@smuzaffar smuzaffar mentioned this pull request Sep 19, 2017
Closed
@cmsbuild
Copy link
Contributor

+1
Tested at: 277cbb7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3431/23094/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3431/23094/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2649068
  • DQMHistoTests: Total failures: 222
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2648657
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

Pull request #3431 was updated.

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 20, 2017 •
edited
Loading

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23106/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 48146f0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3431/23106/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3431/23106/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2649068
  • DQMHistoTests: Total failures: 231
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2648648
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 14 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e9e42ed into cms-sw:IB/CMSSW_9_4_X/gcc630 Sep 20, 2017
This was referenced Sep 21, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smuzaffar smuzaffar smuzaffar left review comments

Assignees
No one assigned
Labels
externals-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrodozov @cmsbuild @smuzaffar @davidlange6