sqlite: use zlib from cms externals #8532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch IB/CMSSW_13_2_X/master. @cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. |
smuzaffar
force-pushed
the
sqlite-zlib-fix
branch
from
3f7a1cb to
8f5de5f
Compare
|
Pull request #8532 was updated. |
In the core sw meeting yesterday my GCC update question should have been on GCC 11 (instead of 12), they just released 11.4, should we look into updating? |
|
ah right, gcc 11.4 was out on 29th May. yes we can already start testing it |
|
closing in favor of #8545 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to build sqlite with zlib from CMS externals
NOTE: As sqlite is used by
python3, so this change rebuilds nearly all the externals. so Do not merge it yet. May be when we have to update the GCC 11 compiler or python3 version then this change can go it.For GCC12 and GCC13, we can already include this change