Print the Pass/Fail/Skip messages in color if the output is a terminal

[fwyzard]

When the output is not a terminal (e.g. a file or a pipe), the output is unchanged:

When the output is a terminal, the "Pass", "Fail" and "Skip" messages are coloured:

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch scramv3.

@iarspider, @smuzaffar, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[fwyzard]

please test

[smuzaffar]

test parameters:

• addpkg = FWCore

[smuzaffar]

please test

lets run tests with few packages checked out

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10f3ab/36630/summary.html
COMMIT: 6c44011
CMSSW: CMSSW_14_0_X_2023-12-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/98/36630/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

[fwyzard]

I think the warning about possibly uninitialised memory are unrelated to these changes ?

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02816/el8_amd64_gcc12/external/boost/1.80.0-9d4e0dc8cf1f8fc8a67cf53ae917955e/include/boost/graph/detail/adj_list_edge_iterator.hpp:80:13: warning: 'MEM[(struct stored_edge_property * const &)&ei + 48]' may be used uninitialized [-Wmaybe-uninitialized]

and

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_pair.h:535:11: warning: 'modRow' may be used uninitialized [-Wmaybe-uninitialized]

[smuzaffar]

@fwyzard , looks like some other issue. Normal PR tests build.log looks like this where you can find multiple scram build stages but the build log for this PR looks truncated

[smuzaffar]

please test

lets rerun the tests

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10f3ab/36638/summary.html
COMMIT: 6c44011
CMSSW: CMSSW_14_0_X_2023-12-21-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/98/36638/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

[smuzaffar]

No idea why build.log gets truncated while running https://github.com/cms-sw/cms-bot/blob/master/pr_testing/test_multiple_prs.sh#L1014

[a]

Copying tmp/el8_amd64_gcc12/src/RecoPPS/Local/src/RecoPPSLocal/libRecoPPSLocal.so to productstore area:
Leaving library rule at RecoPPS/Local
>> Leaving Package RecoPPS/Local
>> Package RecoPPS/Local built
>> Subsystem RecoPPS built
gmake[1]: Entering directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-12-21-1100'
tail: build.log: file truncated
>> Entering Package CalibPPS/ESProducers
>> Leaving Package CalibPPS/ESProducers
>> Package CalibPPS/ESProducers built

[smuzaffar]

@fwyzard , I think writing to /proc/$${PPID}/fd/1 is causing the log file truncation

[fwyzard]

Ah... I'll try with >> .

[cmsbuild]

Pull request #98 was updated.

[fwyzard]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10f3ab/36648/summary.html
COMMIT: 316db38
CMSSW: CMSSW_14_0_X_2023-12-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/98/36648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 88 lines from the logs
• Reco comparison results: 11 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247246
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

@fwyzard , build and tests look good now. By the way, what is the purpose of >> /proc/$${PPID}/fd/1 ?

ifeq ($(shell [ -t 1 ] && echo terminal),terminal)

should work too ... right?

[smuzaffar]

ignore my comment, yes looks like your change does the rigth thing :-)

[fwyzard]

The trick is to make the shell use the same stdout as the parent process, that is make itself.
Otherwise the check applies to the process spawned by make, which is always attached to a pipe and not to a terminal.

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next scramv3 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)