source cmsset_default.sh in the new shell to get alias and crab auto completion working

[smuzaffar]

This change allows to source the cmsset_default.sh via bash --init-file cmsset_default.sh in the newly created shell. This makes sure that alias (e.g. cmsrel, cmsenv) set via cmsset_default.sh are available in the container and auto completion of command e.g. crab also works

@kpedro88 , do you foresee any issue with this change? Or do you have any better suggestion?

[a]

• Auto completion of crab

> /build/muz/x/common/cmssw-el8
Singularity> crab
checkdataset      checkwrite        --debug           getoutput         --help            preparelocal      --quiet           report            setdatasetstatus  status            tasks             --version         
checkusername     createmyproxy     getlog            -h                kill              proceed           remake            resubmit          setfilestatus     submit            uploadlog         
Singularity> exit
exit

• Run one or more commands

> /build/muz/x/common/cmssw-el8 -- echo OK
OK
> /build/muz/x/common/cmssw-el8 -- "echo OK; echo DONE"
OK
DONE
>

• Testing cmsrel alias

> /build/muz/x/common/cmssw-el8 -- "cmsrel CMSSW_14_0_0_pre2; ls CMSSW_14_0_0_pre2"
biglib  bin  cfipython  config  doc  include  lib  logs  objs  python  src  static  test  tmp

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch master.

@smuzaffar, @iarspider, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[smuzaffar]

please test

[kpedro88]

This passes the tests I recently added in https://github.com/cms-sw/cmssw-osenv/tree/master/tests, so it looks fine to me.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6952db/36753/summary.html
COMMIT: f6b08c7
CMSSW: CMSSW_14_0_X_2024-01-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw-osenv/13/36753/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Backport cpp20 changes to master branch cmsdist#8922

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6952db/36753/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6952db/36753/git-merge-result

Comparison Summary

Summary:

• You potentially added 112 lines to the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3247277
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3247252
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 161 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[smuzaffar]

+externals

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[Martin-Grunewald]

Does this work for users with [t]csh as shell?

[smuzaffar]

@Martin-Grunewald , inside the container we only start bash. So yes it should work for users with [t]csh shell but once they are in the singularity env then the shell will be bash

[Martin-Grunewald]

Could I change it by doing /bin/tcsh within the container, do would functionality of the container then be lost?

[smuzaffar]

yes you can change the shell by doing csh or tcsh with in the container. You will still remain in the container env. I am not sure if your new shell will source cmsset_default.csh or not