Skip to content

Commit

Permalink
Merge pull request #11371 from bendavid/ecalloopfixv2_74x
Browse files Browse the repository at this point in the history
add missing break statement to final protection for multifit infinite loops
  • Loading branch information
davidlange6 committed Sep 19, 2015
2 parents 38147a0 + 166c338 commit 07b0b85
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions RecoLocalCalo/EcalRecAlgos/src/PulseChiSqSNNLS.cc
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@ bool PulseChiSqSNNLS::NNLS() {
//worst case protection
if (iter>=500) {
edm::LogWarning("PulseChiSqSNNLS::NNLS()") << "Max Iterations reached at iter " << iter << std::endl;
break;

This comment has been minimized.

Copy link
@smuzaffar

smuzaffar Sep 19, 2015

Contributor

@davidlange6 , may be i am seeing things differently but looks like iter is not changing here. So this protection is not going to trigger

This comment has been minimized.

Copy link
@smuzaffar

smuzaffar Sep 19, 2015

Contributor

oops my bad, i only looked in to the half of the while loop :-) sorry for the noise

}

//unconstrain parameter
Expand Down

0 comments on commit 07b0b85

Please sign in to comment.