-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #11371 from bendavid/ecalloopfixv2_74x
add missing break statement to final protection for multifit infinite loops
- Loading branch information
Showing
1 changed file
with
1 addition
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -322,6 +322,7 @@ bool PulseChiSqSNNLS::NNLS() { | |
//worst case protection | ||
if (iter>=500) { | ||
edm::LogWarning("PulseChiSqSNNLS::NNLS()") << "Max Iterations reached at iter " << iter << std::endl; | ||
break; | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
smuzaffar
Contributor
|
||
} | ||
|
||
//unconstrain parameter | ||
|
@davidlange6 , may be i am seeing things differently but looks like iter is not changing here. So this protection is not going to trigger