Changes suggested by Chris Jones

cms-sw · Sep 23, 2015 · 7b60ff6 · 7b60ff6
1 parent a2c6ad1
commit 7b60ff6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/DataFormats/Common/test/testOwnVector.cc b/DataFormats/Common/test/testOwnVector.cc
@@ -1,8 +1,8 @@
 #include "cppunit/extensions/HelperMacros.h"
 #include <algorithm>
+#include <cstring>
 #include <iterator>
 #include <iostream>
-#include <string.h>
 #include "DataFormats/Common/interface/OwnVector.h"
 #include "DataFormats/Common/interface/Ptr.h"
 

diff --git a/FWCore/Utilities/interface/OffsetToBase.h b/FWCore/Utilities/interface/OffsetToBase.h
@@ -10,16 +10,17 @@
  * A specialization would look something like this
  * (in YourClass.h"
  *
- * #include "FWCore/Utilities/interface/OffsetToBase.h 
+ * #include "FWCore/Utilities/interface/OffsetToBase.h"
  * namespace edm {
  *   template<>
  *   class OffsetToBase<YourClass> {
  *     public OffsetToBase() {}
  *     size_t offsetToBase(std::type_info const& baseTypeInfo) const {
- *       YourClass object;
- *       void const* objectPtr = &object;
+ *       int const dummy = 0;
+ *       YourClass const* object = reinterpret_cast<YourClass const*>(&dummy);
+ *       void const* objectPtr = object;
  *       if(baseTypeInfo == typeid(BaseClass1)) {
- *          BaseClass1 const* base = &object;
+ *          BaseClass1 const* base = object;
  *          void const* basePtr = base;
  *          return static_cast<char const*>(basePtr) - static_cast<char const*>(objectPtr);
  *       }