bsunanda:Run2-alca19 Fix for the crash in the relval for AlCa step with IsoTrack

[bsunanda]

Modify the AlCaRecoProducer fo IsoTrack as well as HBHEMuon and also the fliters/scripts to avoid any crash in RelVal steps. The changes need to be backported to the CMSSW version used in Tier0.

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

bsunanda:Run2-alca19 Fix for the crash in the relval for AlCa step with IsoTrack

It involves the following packages:

Calibration/HcalAlCaRecoProducers

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[mmusich]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 5fcb65b
When I ran the RelVals I found an error in the following worklfows:
135.4 step3

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step3_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

1306.0 step5

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step5_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

1330.0 step5

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15/step5_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15+MINIAODMCUP15.log

4.53 step5

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT/step5_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT+MINIAODDreHLT.log

50202.0 step5

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step5_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log

25202.0 step5

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15/step5_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+MINIAODMCUP15.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10178/6172/summary.html

[bsunanda]

Can this be tested and integrated soon? Regards Sunanda

---

From: cmsbuild [[email protected]]
Sent: 14 July 2015 19:41
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca19 Fix for the crash in the relval for AlCa step with IsoTrack (#10178)

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10178/6201/summary.html

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/10178#issuecomment-121319020.

[diguida]

testing locally in order to see the event content...

[diguida]

@bsunanda from a check of the event content I see that now you have generalTracks, but no more the IsoTrack collection. From a quick check of the code, now you filter out particles, while before you were also putting them in a dedicated collection. Is this correct?

[bsunanda]

Yes - we keep all tracks - more likely it is a filter with 1 extra collection with results from linking isolated tracks with trigger information.

---

From: Salvatore Di Guida [[email protected]]
Sent: 28 September 2015 18:08
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca19 Fix for the crash in the relval for AlCa step with IsoTrack (#10178)

@bsunandahttps://github.com/bsunanda from a check of the event content I see that now you have generalTracks, but no more the IsoTrack collection. From a quick check of the code, now you filter out particles, while before you were also putting them in a dedicated collection. Is this correct?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/10178#issuecomment-143791383.

[diguida]

@bsunanda Bad, I still get 0 events by running wf 25.0...

[diguida]

Ok, but at least it runs without crashing... At this point, I think it is safe to approve here and check the IB relvals and more local tests even on data.

[diguida]

+1
Fixes observed crashes in HcalCalIsoTrkAlCaReco are removed. Still, the filter is not selecting any events.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[bsunanda]

David - could you integrate this PR for pre6?

---

From: cmsbuild [[email protected]]
Sent: 29 September 2015 16:57
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-alca19 Fix for the crash in the relval for AlCa step with IsoTrack (#10178)

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6https://github.com/davidlange6, @deganohttps://github.com/degano, @smuzaffarhttps://github.com/smuzaffar

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/10178#issuecomment-144085990.

[davidlange6]

+1