Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First integration of Pixel Alignment of large structures in PCL (75X) #10451

Merged
merged 63 commits into from
Sep 4, 2015

Conversation

cerminar
Copy link
Contributor

This PR integrates the alignment of the pixel large structures as a
new PCL workflow for Tier0.
There is no code change to any production workflow, only the alca
configurations are affected by the changes.

The new workflow has been integrated in the relval 1001 (which now has
one more step).

vanbesien and others added 30 commits July 28, 2015 11:29
Conflicts:
	Configuration/PyReleaseValidation/python/ConfigBuilder.py
Conflicts:
	Configuration/StandardSequences/python/AlCaRecoStreams_cff.py
* created in CMSSW_7_4_0_pre6
* aligns only tracker
* AP is no longer an ESProducer but an EDAnalyzer
* runs only with MillePede at the moment
* uses EventSetup from first event for init-routines
* created in CMSSW_7_5_0_pre5
* aligns only tracker
* AP is no longer an ESProducer but an EDAnalyzer
* runs only with MillePede at the moment

Conflicts:
	Alignment/CommonAlignmentAlgorithm/interface/AlignmentAlgorithmBase.h
	Alignment/CommonAlignmentProducer/python/TrackerAlignmentProducerForPCL_cff.py
	Alignment/MillePedeAlignmentAlgorithm/src/MillePedeAlignmentAlgorithm.cc
Instead of using a std::vector<FileBlob>, introduced a new class
FileBlobCollection, which is kind of a wrapper around the old vector and
which implements the mergeProduct method. This enables the framework to
merge different files together.
We also update the MillePedeFileConverter to use the new
FileBlobCollection.
(However MillePedeFileExtracter is not yet updated.)
@boudoul
Copy link
Contributor

boudoul commented Aug 10, 2015

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10451/7093/summary.html

The workflows 1001.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

@boudoul
Copy link
Contributor

boudoul commented Aug 10, 2015

+1

@ggovi
Copy link
Contributor

ggovi commented Aug 17, 2015

+1

davidlange6 added a commit that referenced this pull request Sep 4, 2015
First integration of Pixel Alignment of large structures in PCL (75X)
@davidlange6 davidlange6 merged commit 57c324c into cms-sw:CMSSW_7_5_X Sep 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants