Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLT BTV DQM offline #10501

Merged
merged 3 commits into from
Sep 20, 2015
Merged

HLT BTV DQM offline #10501

merged 3 commits into from
Sep 20, 2015

Conversation

silviodonato
Copy link
Contributor

This PR add the DQM offline for the online b-tagging.
It is a follow up of #10017 .
It includes the suggestions by @deguio .
I also added a file to test it in the test folder.

@silviodonato
Copy link
Contributor Author

As soon as it will be approved, I will prepare the backport to 75X and 76X

@silviodonato silviodonato mentioned this pull request Jul 31, 2015
Closed
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Jul 31, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato for CMSSW_7_6_X.

HLT BTV DQM offline

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

Pull request #10501 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Aug 7, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2015

-1
Tested at: 8588705
When I ran the RelVals I found an error in the following worklfows:
4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODreHLT+HARVESTDreHLT.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

50202.0 step3

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step3_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10501/7069/summary.html

@silviodonato
Copy link
Contributor Author

I try it with CMSSW_7_6_X_2015-08-04-2300 and I didn't see any conflict!
What do I have to do? Thanks, Silvio.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 8, 2015

Pull request #10501 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@davidlange6
Copy link
Contributor

did you forget to commit BTVHLTOfflineAnalyzer_cff.py?

On Aug 8, 2015, at 2:26 PM, silviodonato [email protected] wrote:

I try it with CMSSW_7_6_X_2015-08-04-2300 and I didn't see any conflict!
What do I have to do? Thanks, Silvio.

—
Reply to this email directly or view it on GitHub.

@silviodonato
Copy link
Contributor Author

I removed it, and I fixed "DQMOffline_Trigger_cff".
My comment was referring to "This branch has conflicts that must be resolved", not to the fact that the cmsbuild test failed.
Thanks, Silvio.

@deguio
Copy link
Contributor

deguio commented Aug 10, 2015

ciao silvio,
could you please rebase this one? it is not mergeable anymore..
thanks,
F.

@silviodonato
Copy link
Contributor Author

Ok, the problem was that I did't see any conflict in CMSSW_7_6_X_2015-08-04-2300.
Now I rebased with CMSSW_7_6_X_2015-08-10-1100.
Thanks, Silvio.

@cmsbuild
Copy link
Contributor

Pull request #10501 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Aug 12, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 16, 2015

everything is in:
https://github.com/silviodonato/cmssw/blob/BTVHLTDQMOffline/DQMOffline/Trigger/python/DQMOffline_Trigger_cff.py

it is a matter of moving line 52 after:
https://github.com/silviodonato/cmssw/blob/BTVHLTDQMOffline/DQMOffline/Trigger/python/DQMOffline_Trigger_cff.py#L70

F.

@silviodonato
Copy link
Contributor Author

Thanks!

@cmsbuild
Copy link
Contributor

Pull request #10501 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Sep 16, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 16, 2015

+1
@silviodonato please backport this PR to previous cycles where needed.
ciao,
F.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 3aff32a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10501/8114/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10501/8114/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

This was referenced Sep 17, 2015
Merged
Merged
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 20, 2015
@cmsbuild
Merge pull request #10501 from silviodonato/BTVHLTDQMOffline
23a1888 
HLT BTV DQM offline
@cmsbuild cmsbuild merged commit 23a1888 into cms-sw:CMSSW_7_6_X Sep 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
5 participants
@silviodonato @cmsbuild @deguio @davidlange6 @puigh