-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
750 tracking particles PreMixing fixes #10569
750 tracking particles PreMixing fixes #10569
Conversation
Waiting for validation from DPG folks. Don't merge just yet! |
A new Pull Request was created by @mdhildreth for CMSSW_7_5_X. 750 tracking particles PreMixing fixes It involves the following packages: Configuration/PyReleaseValidation @civanch, @boudoul, @srimanob, @mdhildreth, @cmsbuild, @franzoni can you please review it and eventually sign? Thanks. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
@cmsbuild, please test @mdhildreth, @makortel - is this ready now? |
The tests are being triggered in jenkins. |
Pull request #10569 was updated. @civanch, @boudoul, @srimanob, @mdhildreth, @cmsbuild, @franzoni, @davidlange6 can you please check and sign again. |
@davidlange6 I think this is still work in progress (e.g. I understood from @mdhildreth that he would some further developments for muons that I don't see here). But for tracking validation the following works
I have only tested with handful of events and not compared the results to classical mixing, but I can see from MTV output that it gets pileup TrackingParticles and e.g. fake rates have qualitatively similar structure as with classical mixing. Important points
The step3 output will be full of messages like
for whose I understood @mdhildreth should have further developments (not yet fully working). |
Pull request #10569 was updated. @danduggan, @boudoul, @srimanob, @cmsbuild, @franzoni, @deguio, @davidlange6 can you please check and sign again. |
please test |
+1 |
The tests are being triggered in jenkins. |
…xingFixes 750 tracking particles PreMixing fixes
Modify merging of tracking particles to update references between new copies of TrackingParticles and TrackingVertices. Set "validation" mode to be default for first PreMixing stage in RelVals so TrackingParticles are produced automatically.