-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HF Minimum Bias algorithm to Stage1 Emulator #10695
Add HF Minimum Bias algorithm to Stage1 Emulator #10695
Conversation
A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_6_X. Add HF Minimum Bias algorithm to Stage1 Emulator It involves the following packages: L1Trigger/L1TCalorimeter @cmsbuild, @mulhearn can you please review it and eventually sign? Thanks. |
@icali Wanted to be linked in. |
This is fairly urgent, since we are currently taking data using this algorithm in firmware with no matching emulator algorithm. @mulhearn Is there a plan moving forward for this algorithm? |
please test |
Sorry, Alex, was traveling and missed this one... |
The tests are being triggered in jenkins. |
please test |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Add HF Minimum Bias algorithm to Stage1 Emulator
Add HF Minimum Bias algorithm to Stage1 Emulator (backport 74X #10695)
Due to changes in how the minimum bias bits are handled with respect to legacy, the Layer2 emulator needs to handle the minimum bias bits which are transmitted on the HF Bit Counts fiber.
This PR adds the required changes to the Layer2, but because of an upsteam issue with the HCAL digis, only real-data will have non-zero values for this. MC requires a near-future PR to have non-zero Minimum bias bits.
This algorithm was tested against the currently running L1 Firmware by Ben Kreis and I.
@mulhearn You should probably sign off on this.
Expect to see backport PRs for 75X and 74X shortly.