ES DQM fix to the number of good rechits

[cmkuo]

this is to fix a bug when counting the number of good ES rechits

[cmsbuild]

A new Pull Request was created by @cmkuo for CMSSW_7_4_X.

ES DQM fix to the number of good rechits

It involves the following packages:

DQM/EcalPreshowerMonitorModule
RecoEgamma/EgammaPhotonProducers

@cmsbuild, @cvuosalo, @danduggan, @deguio, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @argiro, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

@cmkuo this PR doesn't depend on the MiniAOD changes. Please do something like:

git rebase -i --onto CMSSW_7_4_X_2015-08-16-2300 mydev_74x_ESDQM~1 mydev_74x_ESDQM
git push my-cmssw mydev_74x_ESDQM -f

To separate this pull request from the MiniAOD changes.
Also, please make forward ports (after you rebase) to 75X and 76X.

Thanks!

[slava77]

-1
please rebase as suggested, the reco signature will not be needed after that

[cmsbuild]

Pull request #10815 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 200eb48
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 17-Aug-2015 15:55:07 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

50202.0 N/A

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10815/7379/summary.html

[lgray]

@cmkuo please make forward ports of this to CMSSW_7_5_X and CMSSW_7_6_X

[danduggan]

please test

[danduggan]

@cmkuo could you also push this change to 75 and 76x?

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

-1
Tested at: 200eb48
When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error

1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10815/7557/summary.html

[danduggan]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 200eb48
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10815/7590/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10815/7590/summary.html

[danduggan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1