Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APE tool implemented, PR #10601and PR#12783 backported #10893

Merged
merged 9 commits into from
Jan 5, 2016

Conversation

cschomak
Copy link
Contributor

PR #10601 backported to 74X:
APE tool implemented into the release
TrackerTreeGenerator (necessary for the APE tool, but might also used for other purposes) included in Alignment/TrackerAlignment
Fixes for ApeSettingAlgorithm in CommonAlignmentAlgorithm

PR #12783 backported to APE tool in 74X:
cmsStage, cmsLs, cmsRm statements replaced by xrdcp, eos ls/rm

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cschomak for CMSSW_7_4_X.

APE tool implemented, PR #10601 backported

It involves the following packages:

Alignment/APEEstimation
Alignment/CommonAlignmentAlgorithm
Alignment/TrackerAlignment

The following packages do not have a category, yet:

Alignment/APEEstimation

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Aug 21, 2015

please test

1 similar comment
@mmusich
Copy link
Contributor

mmusich commented Aug 21, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 06fef27
When I ran the RelVals I found an error in the following worklfows:
50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 21-Aug-2015 11:15:10 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 21-Aug-2015 11:15:23 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'digitisation_step'
   [2] Calling event method for module MixingModule/'mix'
Exception Message:
RootInputFileSequence::readOneRandom(): no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

140.53 step1

DAS Error

1000.0 step1

DAS Error

1001.0 step1

DAS Error

1003.0 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10893/7532/summary.html

@cschomak
Copy link
Contributor Author

cschomak commented Sep 3, 2015

Do these failed checks have anything to do with my code? I do not see any connection

@mmusich
Copy link
Contributor

mmusich commented Sep 3, 2015

@cschomak no, sorry this slipped out of my attention

@mmusich
Copy link
Contributor

mmusich commented Sep 3, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #10893 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@cschomak
Copy link
Contributor Author

I changed the GT and replace the cmsStage, cmsLs etc scripts as Gregor suggested

@mmusich
Copy link
Contributor

mmusich commented Dec 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10295/console

@diguida
Copy link
Contributor

diguida commented Dec 15, 2015

@cschomak thanks.
The commit 5c1998e is a back port of gregor-mittag@455f1a5 in #12783 plus the GT change.
Can you please update the description of this PR, please?

@cschomak cschomak changed the title APE tool implemented, PR #10601 backported APE tool implemented, PR #10601and PR#12783 backported Dec 15, 2015
@cmsbuild
Copy link
Contributor

@cschomak
Copy link
Contributor Author

@diguida I changed the title and the description of the PR

@cmsbuild
Copy link
Contributor

@diguida
Copy link
Contributor

diguida commented Dec 15, 2015

+1
Back port of #10601 and 455f1a5 of #12783 in 5c1998e

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 5, 2016
APE tool implemented, PR #10601and PR#12783 backported
@cmsbuild cmsbuild merged commit 8f2513c into cms-sw:CMSSW_7_4_X Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants