Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L1 prescales to the miniAOD #10895

Merged
merged 2 commits into from
Sep 2, 2015

Conversation

gpetruc
Copy link
Contributor

@gpetruc gpetruc commented Aug 21, 2015

Add L1 prescales to the miniAOD

Uses the extended method to get the prescales of the individual L1 bits if there are multiple of them, and saves the maximum and minimum non-zero prescale value.
In the most common cases it should either be l1min = 1 (the path is seeded by at least one unprescaled L1) or l1min = l1max (the path has a single L1 bit, or multiple but all with the same prescale), and this PR should cover them.
Other cases require anyway the user to delve deeper into how the path is seeded, and this can be done following the instructions on https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHighLevelTrigger#L1T_and_HLT_Prescales_for_HLT_pa (runs on MiniAOD, but requires the full framework, correct global tag, etc.)

Will prepare 75X and 76X versions later today or monday

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_4_X.

Add L1 prescales to the miniAOD

It involves the following packages:

PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@monttj
Copy link
Contributor

monttj commented Aug 28, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Aug 30, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Sep 2, 2015
Add L1 prescales to the miniAOD (76X port of #10895)
davidlange6 added a commit that referenced this pull request Sep 2, 2015
Add L1 prescales to the miniAOD (75X port of #10895)
@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 2, 2015
@cmsbuild cmsbuild merged commit 9436a18 into cms-sw:CMSSW_7_4_X Sep 2, 2015
@gpetruc gpetruc deleted the gp-l1prescales-74X branch September 30, 2015 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants