-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FWLite MultiChainEvent: avoid crash on empty files (75X) #10896
FWLite MultiChainEvent: avoid crash on empty files (75X) #10896
Conversation
… primary input files have all zero events
…for event in events' still works (and does nothing) when there are no files
A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_5_X. FWLite MultiChainEvent: avoid crash on empty files (75X) It involves the following packages: DataFormats/FWLite @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
-1 DAS Error 1001.0 step1 DAS Error 1003.0 step1 DAS Error you can see the results of the tests here: |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (but tests are reportedly failing). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
…-crash-75X FWLite MultiChainEvent: avoid crash on empty files (75X)
Forward port of #10739. Tested in
CMSSW_7_5_X_2015-08-20-2300
(both that it is needed and that it works)