-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform RecoTrackRefSelector to stream (75X) #10912
Transform RecoTrackRefSelector to stream (75X) #10912
Conversation
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_5_X. Transform RecoTrackRefSelector to stream (75X) It involves the following packages: CommonTools/RecoAlgos @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
-1 DAS Error you can see the results of the tests here: |
@cmsbuild please test
|
The tests are being triggered in jenkins. |
+1 Making RecoTrackRefSelector a stream module. There should be no change in monitored quantities. This PR is a backport of a part of #10911 (76X); the latter has already been approved by Reco. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-24-1100 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Transform RecoTrackRefSelector to stream (75X)
track this at #10965 |
Backport of #10911:
This is a minimal change to make RecoTrackRefSelector a stream module (i.e. easily back-portable).
Tested in 7_5_2, no changes expected in results.
@rovere @VinInn @fwyzard