Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic strip reco 75 x #10925

Merged
merged 24 commits into from
Sep 4, 2015
Merged

Dynamic strip reco 75 x #10925

merged 24 commits into from
Sep 4, 2015

Conversation

andrewj314
Copy link
Contributor

Backport of PR #10805 to 7_5_X

Christian and others added 24 commits August 24, 2015 18:46
@andrewj314
- dynamic strip reconstruction for Yuta
db506f5 
- added Loose, Medium and Tight tau ID discriminators with pileup weighted isolation
- removal of deprecated tau ID discriminators from pat::Taus
@andrewj314
fixed typo in discriminator name
f36c8f5
@andrewj314
bug-fix in storing of (raw) footprint correction
bbbbd05
@andrewj314
- store neutral pileup weighted isolation pT sum
e48dd87 
- bug-fix: disable deltaBeta corrections for pileup weighted isolation discriminators
@andrewj314
added pileup weighted neutral isolation
f3096e7
@andrewj314
fixed typo in discriminator name
92cf37e
@andrewj314
updated parameters for dynamic strip reconstruction
db7a750
@andrewj314
sutract 2 GeV from k offset values (except for 3prong0pi0), as recomm…
d3677b7 
…ended by Yuta
@anehrkor @andrewj314
New cleaner module that works also if tau is made up of combination of
b56551f 
pf charged hadrons and tracks -> solves rare problem with 3-prongs
having charge +/-3.
@andrewj314
added functionality to make tau footprint correction dependent on tauPt
b1b1e43
@andrewj314
tightened cut on pTouter from 0.20*tauPt to 0.10*tauPt
d710b81
@andrewj314
apply cut on ptOuter also in case of HPS combined islation 3-hit disc…
f85bf27 
…riminators with deltaBeta correction
@andrewj314
- updated deltaBeta correction factor to 0.2
fbff232 
- updated thresholds for isolation WPs:
     Loose = 2.5 GeV
     Medium = 1.5 GeV
     Tight = 0.8 GeV (no change)
@andrewj314
updates to tau vertex producers from Arun
6726894
@andrewj314
updated patTau selection to use new discriminators
ecb6a9d
@andrewj314
Added missing discriminators to updateHPSPFTaus_cff.py - their absenc…
113058c 
…e was causing unit tests to fail.
@andrewj314
Added import statements whose absence was causing the unit tests to fail
bd3c836
@andrewj314
New attempt to add Dynamic Strip Reco to 7_6_X - a new PR was necessa…
7d7893b 
…ry because of a rebase while debugging

Previous PR at: cms-sw#10215
@andrewj314
Added fillDescriptions() method, reverted HLT dumps to previous versi…
629d89c 
…on since they may not be modified. Now failing unit test 1330.0 as well as 135.4. Attempting to diagnose

but updating the PR anyway to iterate with the experts.
@andrewj314
Added Christian's alternate fix to the HLT issues. Now passing all te…
644f8bd 
…sts except 135.4 (missing module label: combinatoricRecoTaus)
@andrewj314
Per Slava's suggestion, removed modules from cms.Sequence and added t…
ccfc093 
…hem to import section instead. Now runTheMatrix passes all tests!!!
@andrewj314
Attempting to implement Slava's suggestions after his review of PR 10…
112c722 
…605. Code compiles but segfaults on several matrix tests - currently attempting to diagnose with GDB but

sharing with the experts anyway.
@andrewj314
Applied Slava's suggestions in PR 10605+10802, now passing all tests!
b95b7a5
@andrewj314
Bugfix adding absolute value to deltaPhi, changing BOOSTFOREACH loops…
33f9993 
… to auto iterators
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 24, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @andrewj314 (AJ Johnson) for CMSSW_7_5_X.

Dynamic strip reco 75 x

It involves the following packages:

CommonTools/ParticleFlow
DataFormats/TauReco
PhysicsTools/PatAlgos
RecoTauTag/Configuration
RecoTauTag/RecoTau

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @ahinzmann, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Aug 25, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Aug 25, 2015

+1

for #10925 33f9993

  • backport is done correctly (the same code changes are applied as in the 76X version Dynamic strip reco v4 #10805 83ed5d2)
  • tested additionally locally in CMSSW_7_5_X_2015-08-20-2300 /test area sign573/ with a short matrix and a run2 prompt-reco workflow. Changes are consistent with the changes observed in 76X tests (spot checks of a few performance numbers and plots show essentially the same differences)
    • DQM and fwlite reco comparisons show differences only in tau plots
    • 7 producers removed, 11 producers added: net change in CPU is within 10ms/evt (0.1% of the job)

@cmsbuild
Copy link
Contributor

+1
Tested at: 33f9993
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10925/7624/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10925/7624/summary.html

@slava77
Copy link
Contributor

slava77 commented Aug 31, 2015

@monttj
please check
we are waiting for your signature here

@monttj
Copy link
Contributor

monttj commented Sep 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 4, 2015
@cmsbuild
Merge pull request #10925 from cms-tau-pog/DynamicStripReco_75X
3ebbeec 
Dynamic strip reco 75 x
@cmsbuild cmsbuild merged commit 3ebbeec into cms-sw:CMSSW_7_5_X Sep 4, 2015
@roger-wolf roger-wolf deleted the DynamicStripReco_75X branch March 24, 2016 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.
6 participants
@andrewj314 @cmsbuild @slava77 @monttj @davidlange6 @anehrkor