boundary check

[BetterWang]

Backport of #10947
error: array subscript [-Werror=array-bounds]
added limit checks to header code

[cmsbuild]

A new Pull Request was created by @BetterWang (Quan Wang) for CMSSW_7_5_X.

boundary check

It involves the following packages:

RecoHI/HiEvtPlaneAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@jazzitup, @dgulhan, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @richard-cms, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 9ab4795
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10948/7654/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10948/7654/summary.html

[cvuosalo]

+1

For #10948 9ab4795

Small fix to prevent array-boundary warnings from the compiler. No change in run-time behavior should occur. The 76X version of this PR, #10947, has already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-08-24-1100 show no significant differences, as expected.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1