Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate modules used by the HLT menu to multithreading (various) (75x) #10970

Merged
merged 5 commits into from
Sep 9, 2015
Merged

migrate modules used by the HLT menu to multithreading (various) (75x) #10970

merged 5 commits into from
Sep 9, 2015

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Aug 27, 2015

backport #10958 to 75x

@fwyzard
cleanup some const_cast
646526a 
  - L1GtVhdlWriterCore: get rid of an unnecessary const_cast
  - L1GtTriggerMenuXmlParser: fix the input parameter of strtol
This was referenced Aug 27, 2015
Closed
Closed
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Aug 27, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_5_X.

migrate to modules used by the HLT menu multithreading (part 1)

It involves the following packages:

HLTrigger/HLTcore
HLTrigger/HLTfilters
L1Trigger/GlobalTrigger
L1TriggerConfig/L1GtConfigProducers

@Martin-Grunewald, @perrotta, @cmsbuild, @mulhearn, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard fwyzard force-pushed the migrate_to_multithreading_75x_part1 branch 2 times, most recently from 978abf1 to dca8ada Compare August 27, 2015 07:41
fwyzard added 3 commits August 27, 2015 09:46
@fwyzard
fix use of L1GtTriggerMenu
cc5ec5c 
L1GtTriggerMenu is now properly initialised by the EventSetup framework,
so there is no longer need to call

  (const_cast<L1GtTriggerMenu *>(l1GtTriggerMenu))->buildGtConditionMap();

or to keep a local copy for that purpose
@fwyzard
L1GlobalTrigger: change into a stream::EDProducer
56d36ae 
  - change most configuration parameters into const members
  - change into a stream::EDProducer
@fwyzard
TriggerResultsFilter: change into a edm::stream::EDFilter
80fa995
@fwyzard fwyzard force-pushed the migrate_to_multithreading_75x_part1 branch from e513792 to 80fa995 Compare August 27, 2015 07:46
@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 27, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #10970 was updated. @perrotta, @cmsbuild, @danduggan, @monttj, @Martin-Grunewald, @deguio, @fwyzard, @ggovi, @vadler, @mulhearn can you please check and sign again.

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 27, 2015

+1

@fwyzard
Copy link
Contributor Author

fwyzard commented Aug 27, 2015

tracked at #10965

@cmsbuild
Copy link
Contributor

+1
Tested at: 80fa995
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10970/7679/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10970/7679/summary.html

@fwyzard fwyzard changed the title migrate to modules used by the HLT menu multithreading (part 1) migrate to modules used by the HLT menu multithreading (various) Aug 30, 2015
@fwyzard fwyzard changed the title migrate to modules used by the HLT menu multithreading (various) migrate to modules used by the HLT menu multithreading (various) (75x) Aug 30, 2015
@mulhearn
Copy link
Contributor

mulhearn commented Sep 1, 2015

+1

@mulhearn
Copy link
Contributor

mulhearn commented Sep 1, 2015

Thanks, Andrea.

@deguio
Copy link
Contributor

deguio commented Sep 1, 2015

+1

@ggovi
Copy link
Contributor

ggovi commented Sep 1, 2015

+1

@fwyzard fwyzard changed the title migrate to modules used by the HLT menu multithreading (various) (75x) migrate modules used by the HLT menu to multithreading (various) (75x) Sep 2, 2015
davidlange6 added a commit that referenced this pull request Sep 9, 2015
@davidlange6
Merge pull request #10970 from fwyzard/migrate_to_multithreading_75x_…
c3e77d3 
…part1

migrate modules used by the HLT menu to multithreading (various) (75x)
@davidlange6 davidlange6 merged commit c3e77d3 into cms-sw:CMSSW_7_5_X Sep 9, 2015
@fwyzard fwyzard mentioned this pull request Sep 21, 2015
Merged
@fwyzard fwyzard deleted the migrate_to_multithreading_75x_part1 branch September 23, 2015 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending comparison-available dqm-approved hlt-approved l1-approved orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.
7 participants
@fwyzard @cmsbuild @mulhearn @deguio @ggovi @Dr15Jones @davidlange6