Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PoolDBESSource_cfi - properly moved to V2 #10986

Merged

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Aug 27, 2015

This fix complete the move to V2 for the cfg files provided with CondCore/ESSources package (76X version)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_7_6_X.

Fix for PoolDBESSource_cfi - properly moved to V2

It involves the following packages:

CondCore/CondDB
CondCore/ESSources

@ggovi, @cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

@ggovi
Can you please make a PR for 75X as well?
Thanks!

@Martin-Grunewald
Copy link
Contributor

Ah, never mind, I now see it is #10978
Thanks!

@mmusich
Copy link
Contributor

mmusich commented Aug 28, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@ggovi
Copy link
Contributor Author

ggovi commented Aug 28, 2015

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

@ggovi
Copy link
Contributor Author

ggovi commented Sep 23, 2015

@mmusich ping!!

@mmusich
Copy link
Contributor

mmusich commented Sep 23, 2015

+1
pong!

cmsbuild added a commit that referenced this pull request Sep 23, 2015
Fix for PoolDBESSource_cfi - properly moved to V2
@cmsbuild cmsbuild merged commit a800358 into cms-sw:CMSSW_7_6_X Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants