fix histo scales, add ngood vertex

[VinInn]

fix bugs and add flexibility
adapt to current 2015 running

make sense only if in production before end of TS2

[VinInn]

is forward port automatic?

[cmsbuild]

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_4_X.

fix histo scales, add ngood vertex

It involves the following packages:

DQMOffline/RecoB

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @rociovilar, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[smuzaffar]

@VinInn, forward port is automatic only for 75X to 76X.

[VinInn]

will manual port then

[smuzaffar]

yes manual in a sense that you have to create a different PR for 75x

[slava77]

In any case, check if the 76X version didn't diverge from what's in 75X.
Otherwise, a forward port may not work and this issue detection is not
very clear, AFAIK.

On 8/29/15 2:29 PM, Malik Shahzad Muzaffar wrote:

yes manual in a sense that you have to create a different PR for 75x

—
Reply to this email directly or view it on GitHub
#11026 (comment).

[cmsbuild]

Pull request #11026 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

[VinInn]

@cmsbuild please test

[davidlange6]

@cmsbuild, please test

On Aug 31, 2015, at 2:54 PM, Slava Krutelyov [email protected] wrote:

In any case, check if the 76X version didn't diverge from what's in 75X.
Otherwise, a forward port may not work and this issue detection is not
very clear, AFAIK.

On 8/29/15 2:29 PM, Malik Shahzad Muzaffar wrote:

yes manual in a sense that you have to create a different PR for 75x

—
Reply to this email directly or view it on GitHub
#11026 (comment).

—
Reply to this email directly or view it on GitHub.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 316a074
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11026/7767/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11026/7767/summary.html

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[rovere]

Also in this case, I need to have this approved to push another PR on top.

[davidlange6]

+1