Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74X 25ns HLT round three #11041

Merged
merged 5 commits into from
Sep 27, 2015
Merged

Conversation

Martin-Grunewald
Copy link
Contributor

74X 25ns HLT round three of 25ns HLT menu updates
Based on 7410patch1
Includes previous PR #10834

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_4_X.

74X 25ns HLT round three

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@ghellwig, @geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@perrotta
Copy link
Contributor

perrotta commented Sep 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

Pull request #11041 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

@perrotta
Copy link
Contributor

perrotta commented Sep 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

Pull request #11041 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

-1
Tested at: 64dedc1
When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11041/7887/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9a32058
b1418bc
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11041/7887/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11041/7887/git-merge-result

@davidlange6
Copy link
Contributor

@Martin-Grunewald - do you see why this changes the default workflows? (at least thats what the PR tests say)

@Martin-Grunewald
Copy link
Contributor Author

@davidlange6
The frozen MC menus were not changed, but the development menus are changed, of course.
Also, we fixed some event-content bugs to recover DQM, so it may be related to that.
What workflow specifically?

@davidlange6
Copy link
Contributor

I looked at 25202 and 50202

On Sep 16, 2015, at 12:46 PM, Martin Grunewald <[email protected]mailto:[email protected]> wrote:

@davidlange6https://github.com/davidlange6
The frozen MC menus were not changed, but the development menus are changed, of course.
Also, we fixed some event-content bugs to recover DQM, so it may be related to that.
What workflow specifically?


Reply to this email directly or view it on GitHubhttps://github.com//pull/11041#issuecomment-140703153.

@Martin-Grunewald
Copy link
Contributor Author

These 2 are fullsim MC worklfows which run the frozen HLT menus '25ns14e33_v1' or '50ns_5e33_v1', and those HLT menus are not changed in this PR. So I can only assume there is a non-reproducability issue here somewhere in CMSSW.

@Martin-Grunewald
Copy link
Contributor Author

Hmm, I see in the comparison GUI lots of changes unrelated to HLT (eg, JETs), and since this
PR does not change anything outside HLT, I am afraid it must be something else
such as the reproducability issue.

@davidlange6
Copy link
Contributor

@cmsbuild, please test
indeed, there are hlt and jet changes, so lets try again

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@Martin-Grunewald
Copy link
Contributor Author

@davidlange6
I reran by hand base and base+PR in CMSSW_7_4_X_2015-09-20-2300
and for the HLT detailed log of events passing thru modules, there
is no difference for 50202. So at this stage I do not understand the jenkins report.

@cmsbuild cmsbuild merged commit d60aec7 into cms-sw:CMSSW_7_4_X Sep 27, 2015
@Martin-Grunewald Martin-Grunewald deleted the 74X25nsHLT branch November 15, 2015 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants