-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQMStore::removeElement: do not remove non-existing MEs (75x) #11049
DQMStore::removeElement: do not remove non-existing MEs (75x) #11049
Conversation
The previous logic would not prevent calling data_.erase(data_.end()) when the requested MonitorElement does not exist, and warning is false.
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_5_X. DQMStore::removeElement: do not remove non-existing MEs (75x) It involves the following packages: DQMServices/Core @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
…remove_non-existing_MEs DQMStore::removeElement: do not remove non-existing MEs (75x)
The previous logic would not prevent calling
when the requested MonitorElement does not exist, and
warning
is false.