Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase PR#10798 Update standard EventContent definitions #11068

Merged
merged 139 commits into from
Sep 29, 2015
Merged

Rebase PR#10798 Update standard EventContent definitions #11068

merged 139 commits into from
Sep 29, 2015

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Sep 1, 2015

"Fix Conflicts"

jeongeun added 30 commits August 14, 2015 18:31
@jeongeun
Update RecoMET_EventContent_cff.py
e976f10 
Update the standard RECO and AOD EventContent definitions
to add missing Module ('keep recoPFMETs_pfMetEI_*_*',)
to fix Label name ('keep recoMuonMETCorrectionDataedmValueMap_muonMETValueMapProducer_muCorrData_*',)
and change the wildcards to specific Type and Modules (#'keep *HaloData_*_*_*',)
@jeongeun
Update RecoMET_EventContent_cff.py
224fd18
@jeongeun
Update RecoMuon_EventContent_cff.py
9145036 
Update the standard RECO and AOD EventContent definitions 
to remove lines (no such Modules in EventContent)
@jeongeun
Update muIsolation_EventContent_cff.py
51df926 
Update the standard RECO and AOD EventContent definitions 
to remove some line ( no such Module in EventContent)
@jeongeun
Update RecoTauTag_EventContent_cff.py
b8ed587 
Update the standard RECO and AOD EventContent definitions 
to remove wildcards and replaced with specific module names
#'keep *_hpsPFTauDiscrimination*_*_*', --> 'keep *_hpsPFTauDiscriminationByDeadECALElectronRejection_*_*' .. etc
#'keep *_hpsPFTau*PtSum_*_*',  -->  'keep *_hpsPFTauMVA3IsolationChargedIsoPtSum_*_*', .. etc
@jeongeun
Update RecoVertex_EventContent_cff.py
f308fd8 
Update the standard RECO and AOD EventContent definitions 
 and remove some line ( no such Module in EventContent)
@jeongeun
Update RecoEgamma_EventContent_cff.py
631bc23 
Updating the standard RECO and AOD EventContent definitions
to fix module name
and to remove some lines.(no such Module in EventContent)
@jeongeun
Update RecoParticleFlow_EventContent_cff.py
a7f7a92 
Update the standard RECO and AOD EventContent definitions
to change Module names
and remove some line ( no such Module in EventContent)
@jeongeun
Update L1Trigger_EventContent_cff.py
865fd6f 
Update the standard RECO and AOD EventContent definitions 
add Type name and remove some lines ( no such Modules in event content)
@jeongeun
Update EITopPAG_EventContent_cff.py
ac11c45 
Update the standard RECO and AOD EventContent definitions
to change Module name from  pfTausDiscrimination* to pfTausDiscriminationByDecayModeFinding, pfTausDiscriminationByIsolation
and add Type names
@jeongeun
Update HLTrigger_EventContent_cff.py
c0f3468 
Update the standard RECO and AOD EventContent definitions 
to add Module or Type names
@jeongeun
Update Scalers_EventContent_cff.py
d82b23f 
Update the standard RECO and AOD EventContent definitions 
to replace with specific Module name and remove wildcard .
#'keep L1AcceptBunchCrossings_*_*_*', --> 'keep L1AcceptBunchCrossings_scalersRawToDigi_*_*',
@jeongeun
Update MicroEventContent_cff.py
91c2366 
 update the standard event content definitions to have no wildcards of module
#'keep double_fixedGridRho*__*', --> 'keep double_fixedGridRhoAll__*', ...etc
to add specific Module and Label names
Add 'keep *_slimmedMETsPuppi_*_*', 
#'keep recoPhotonCores_reducedEgamma_*_*',  --> 'keep recoPhotonCores_reducedEgamma_reducedGedPhotonCores_*',
@jeongeun
Update RecoJets_EventContent_cff.py
246c7cf
@jeongeun
Update RecoEgamma_EventContent_cff.py
66df19f
@jeongeun
Update RecoLocalCalo_EventContent_cff.py
9618f3b 
Replacing the wildcard in the Module filed with specific Module
@jeongeun
Update RecoMET_EventContent_cff.py
17fb95e
@jeongeun
Update RecoMuon_EventContent_cff.py
1db01ec
@jeongeun
Update RecoParticleFlow_EventContent_cff.py
0c033bc
@jeongeun
Update RecoTracker_EventContent_cff.py
158e1f2 
Updating the standard RECO and AOD EventContent definitions
to fix the Label name.
#'keep *_generalTracks_MVAValues_*', -->  'keep *_generalTracks_MVAVals_*',
@jeongeun
Update RecoVertex_EventContent_cff.py
a3f9153
@jeongeun
Update L1Trigger_EventContent_cff.py
9782b13
@jeongeun
Update HLTrigger_EventContent_cff.py
7c04ef7
@jeongeun
Update MicroEventContent_cff.py
d6b1c8a
@jeongeun
Update RecoLocalTracker_EventContent_cff.py
165d516
@jeongeun
Update HLTrigger_EventContent_cff.py
3e8fb2b
@jeongeun
Update L1Trigger_EventContent_cff.py
28e3726 
Undo
@jeongeun
Update L1Trigger_EventContent_cff.py
c7b9b4e 
Undo
@jeongeun
Update RecoHiJets_EventContent_cff.py
24183e1
@jeongeun
Update RecoHiEgamma_EventContent_cff.py
6c1fdcf
@cmsbuild
Copy link
Contributor

+1
Tested at: 17a054f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11068/8062/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11068/8062/summary.html

@cvuosalo
Copy link
Contributor

+1

For #11068 17a054f

Expanding wildcards to be more specific for event content statements. There should be no change in run-time behavior or resulting event content.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-13-1100 show no significant differences, as expected. An extended test of workflow 25202.0_TTbar_13 with 70 events against baseline CMSSW_7_6_0_pre4 shows no significant differences and no change in event content.

@slava77
Copy link
Contributor

slava77 commented Sep 18, 2015

@monttj @diguida @mmusich
please check this PR, your signature is needed
Thank you.

@slava77
Copy link
Contributor

slava77 commented Sep 28, 2015

@monttj @diguida @mmusich
please check this PR, your signature is needed
Thank you.

@monttj
Copy link
Contributor

monttj commented Sep 29, 2015

+1
It is to make the output contents more specific in AT side.

@diguida
Copy link
Contributor

diguida commented Sep 29, 2015

+1
No changes in the event content expected for AlCa: specifying the collections without wildcards.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 29, 2015
@cmsbuild
Merge pull request #11068 from jeongeun/patch-10
ff47886 
Rebase PR#10798 Update standard EventContent definitions
@cmsbuild cmsbuild merged commit ff47886 into cms-sw:CMSSW_7_6_X Sep 29, 2015
@cvuosalo cvuosalo mentioned this pull request Dec 2, 2015
Merged
gpetruc added a commit to gpetruc/cmssw that referenced this pull request Feb 4, 2016
@gpetruc
Recover metNoHF (was dropped by mistake in cms-sw#11068)
09bd5b3
@gpetruc gpetruc mentioned this pull request Feb 4, 2016
Merged
davidlange6 added a commit that referenced this pull request Feb 5, 2016
@davidlange6
Merge pull request #13192 from gpetruc/metNoHF_80X
fd07d6b 
Recover metNoHF (was dropped by mistake in #11068)
cmsbuild pushed a commit that referenced this pull request Feb 5, 2016
@gpetruc @cmsbuild
Recover metNoHF (was dropped by mistake in #11068)
8b426f0 
(cherry picked from commit 09bd5b3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved analysis-approved comparison-available fully-signed reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
7 participants
@jeongeun @cmsbuild @cvuosalo @slava77 @monttj @diguida @davidlange6