Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Followup on flavor definition in MiniAOD #11076

Merged
merged 4 commits into from
Sep 9, 2015

Conversation

ahinzmann
Copy link
Contributor

Followup on #10751
Due to comments in #10750

Add jetFlavourInfo to ak4 and ak8 jet collections, to be able to identify gluon splitting to bb.
Add lepton matching for identification of hadronic taus.

With this scheme:
b,c can be identified by either j.hadronFlavour() (hadron definition) or j.partonFlavour() (algorithmic definition) or j.genParton().pdgId() (physics definition)
g,u,d,s can be identified by j.genParton().pdgId() (physics definition)
gluon splitting to bb can be identified roughly by (j.genParton().pdgId()==21 && len(j.jetFlavourInfo().getbHadrons())==2 )

The size increase (edmEventSize) for MiniAOD (on 1300 ttbar events) when adding JetFlavourInfo and lepton matching is the following:
without JetFlavourInfo:
patJets_slimmedJets__PAT. 32977.1 2663.08
patJets_slimmedJetsAK8__PAT. 1141.85 251.157
with JetFlavourInfo:
patJets_slimmedJets__PAT. 33015.2 2696.82
patJets_slimmedJetsAK8__PAT. 1144.26 252.791
with lepton matching:
patJets_slimmedJets__PAT. 33025.3 2707.15
patJets_slimmedJetsAK8__PAT. 1144.78 253.252

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

A new Pull Request was created by @ahinzmann for CMSSW_7_5_X.

Followup on flavor definition in MiniAOD

It involves the following packages:

PhysicsTools/JetMCAlgos
PhysicsTools/PatAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

Pull request #11076 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

Pull request #11076 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@monttj
Copy link
Contributor

monttj commented Sep 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2015

@monttj
Copy link
Contributor

monttj commented Sep 3, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@@ -4,7 +4,7 @@
jets = cms.InputTag("ak5PFJets"),
bHadrons = cms.InputTag("selectedHadronsAndPartons","bHadrons"),
cHadrons = cms.InputTag("selectedHadronsAndPartons","cHadrons"),
partons = cms.InputTag("selectedHadronsAndPartons","physicsPartons"),
partons = cms.InputTag("selectedHadronsAndPartons","algorithmicPartons"),
leptons = cms.InputTag("selectedHadronsAndPartons","leptons"),
jetAlgorithm = cms.string("AntiKt"),
rParam = cms.double(0.5),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also set hadronFlavourHasPriority to False here and in AK4PFJetsMCFlavourInfos_cfi.py and propagate these changes to #11077? Thanks.

@davidlange6
Copy link
Contributor

@ahinzmann , all, could this comment from @ferencek be addressed quickly both here and in #11077 so we can finalize the miniaod software.

@arizzi

@ahinzmann
Copy link
Contributor Author

ok working on it.

@ahinzmann
Copy link
Contributor Author

ok, ready to test in 74, 75 and 76.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

Pull request #11076 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

@monttj
Copy link
Contributor

monttj commented Sep 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

davidlange6 added a commit that referenced this pull request Sep 9, 2015
Followup on flavor definition in MiniAOD
@davidlange6 davidlange6 merged commit 0056c41 into cms-sw:CMSSW_7_5_X Sep 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants