Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DQM Validation plots for MSSM Hbb Trigger Paths. #11103

Merged
merged 6 commits into from
Sep 21, 2015
Merged

add DQM Validation plots for MSSM Hbb Trigger Paths. #11103

merged 6 commits into from
Sep 21, 2015

Conversation

heppye
Copy link
Contributor

@heppye heppye commented Sep 3, 2015

add DQM Validation plots for MSSM Hbb Trigger Paths.

@heppye heppye mentioned this pull request Sep 3, 2015
Closed
@cmsbuild cmsbuild added this to the Next CMSSW_7_4_X milestone Sep 3, 2015
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

A new Pull Request was created by @heppye (Ye Chen) for CMSSW_7_4_X.

add DQM Validation plots for MSSM Hbb Trigger Paths.

It involves the following packages:

HLTriggerOffline/Higgs

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@heppye
Copy link
Contributor Author

heppye commented Sep 3, 2015

a rebasing version for the original PR #10550.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

+1
Tested at: c597599
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11103/7867/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2015

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11103/7867/summary.html

@heppye
Copy link
Contributor Author

heppye commented Sep 4, 2015

@davidlange6, thanks for your quick response. @deguio , could you please check the PR again?

deguio
deguio reviewed Sep 11, 2015
View reviewed changes
HLTriggerOffline/Higgs/python/hltHiggsPostProcessors_cff.py
@@ -320,6 +320,24 @@ def get_reco_strings(strings):
hltHiggsPostWHToENuBB.subDirs = ['HLT/Higgs/WHToENuBB']
hltHiggsPostWHToENuBB.efficiencyProfile = efficiency_strings_WHToENuBB

#Specific plots for MSSMHbb
#Jet plots
NMinOneCuts = _config.MSSMHbb.NminOneCuts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is a typo.
NMinOneCuts should be NminOneCuts

@deguio
Copy link
Contributor

deguio commented Sep 11, 2015

please see my comment. in case the same fix should be submitted for 75 and 76 as well.
thanks,
F.

@heppye
Copy link
Contributor Author

heppye commented Sep 14, 2015

@deguio, fixing done. PR for CMSSW_7_6_X #11235 and PR for CMSSW_7_5_X #11234 have been made as well. I am sorry for the mistakes.

@cmsbuild
Copy link
Contributor

Pull request #11103 was updated. @cmsbuild, @danduggan, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Sep 14, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 14, 2015

+1
provided it passes the tests

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@deguio deguio mentioned this pull request Sep 14, 2015
Closed
@cmsbuild
Copy link
Contributor

+1
Tested at: 8556682
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11103/8050/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11103/8050/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 21, 2015
@cmsbuild
Merge pull request #11103 from heppye/patch-10
3c7bd4e 
add DQM Validation plots for MSSM Hbb Trigger Paths.
@cmsbuild cmsbuild merged commit 3c7bd4e into cms-sw:CMSSW_7_4_X Sep 21, 2015
@heppye heppye deleted the patch-10 branch April 3, 2016 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_4_X
Development

Successfully merging this pull request may close these issues.
4 participants
@heppye @cmsbuild @davidlange6 @deguio