-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cmssw 7 5 x l1 gt utils #11124
Cmssw 7 5 x l1 gt utils #11124
Conversation
Remove the arbitrariness of choosing the input tag for L1GlobalTriggerReadoutRecord product when the input tag is retrieved from provenance and more products of this type exist, with different input tags. The code will look for the corresponding product in ProductRegistry. If the product is found, it checks the product label in a vector of preferred input tags (hardwired now to "gtDigis" and "hltGtDigis"). The first input tag from the vector of preferred input tags, with the same label as the input tag found from provenance, is kept as input tag, if there are no multiple products with the same label. If multiple products are found and no one has a label in the vector of preferred input tags, or if multiple products are found with the label in the vector of preferred input tags (with different instance or process) the input tag is set to empty input tag, and L1GtUtil will produce an error, as it is not possible to safely choose a product. In this case, one must provide explicitly the correct input tag via configuration or in the constructor. The same treatment is applied to L1GlobalTriggerRecord and L1GtTriggerMenuLite.
A new Pull Request was created by @vasile-ghete for CMSSW_7_5_X. Cmssw 7 5 x l1 gt utils It involves the following packages: L1Trigger/GlobalTriggerAnalyzer @cmsbuild, @mulhearn can you please review it and eventually sign? Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
please test |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Input tag for L1GlobalTriggerReadoutRecord from provenance.