Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scouting electron, photon, and muon classes and producers #11133

Conversation

davidsheffield
Copy link
Contributor

Backport of #11132.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

A new Pull Request was created by @davidsheffield (David Sheffield) for CMSSW_7_4_X.

Add scouting electron, photon, and muon classes and producers

It involves the following packages:

DataFormats/Scouting
HLTrigger/Egamma
HLTrigger/Muon

The following packages do not have a category, yet:

DataFormats/Scouting

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @abbiendi, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@@ -0,0 +1,7 @@
<library file="*.cc" name="HLTriggerEgammaPlugins">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HLTrigger/Egamma already defines only plugins (in the /src directory), you should not use a new /plugins directory, just put the .cc files in the /src directory.

@fwyzard
Copy link
Contributor

fwyzard commented Sep 4, 2015

-1

@davidsheffield
Copy link
Contributor Author

@fwyzard I have moved the plugins to the src directories.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

Pull request #11133 was updated. @Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please check and sign again.

@fwyzard
Copy link
Contributor

fwyzard commented Sep 4, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 4, 2015

@Martin-Grunewald
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Sep 16, 2015
…tonsPhoton

Add scouting electron, photon, and muon classes and producers
@davidlange6 davidlange6 merged commit 37018fb into cms-sw:CMSSW_7_4_X Sep 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants