cleanup of uninitialized reads reported by valgrind (backport of #11173 )

[slava77]

A fraction of uninitialized value reads reported by valgrind in wflow 4.53 step3 is cleaned up.
The following summary is based on tests in 76X with #11173

• PileupJetIdAlgo is buggy and will need to be fixed by JME developers (I will start a separate thread for this). I have just gotten rid of uninitialized reads.
  • confirmed with valgrind as fixed
• HcalZDCMonitor counters initialized (cleans up occasional NANs in the plots)
  • confirmed with valgrind as fixed
• B2GDQM was missing initialization of semiE_LepJetPtCut (the default uninitialized value was between zero and any other value; it now becomes 30 GeV as desired in the config). Corresponding plots will change.
  • confirmed with valgrind as fixed
• EcalClusterLazyToolsBase had reads beyond vector size (should be harmless from the logic)
  • confirmed with valgrind as fixed
• patPFMETCorrections changes appear to be cosmetic
  • the invalid read in SmearedJetProducerT calling StringCutObjectSelector still remains
• changes in cscdqm::StripClusterFinder are towards cleaning of uninitialized values in StripClusterFitData::height_
  • cleanup is not confirmed by valgrind

Tested in CMSSW_7_5_X_2015-09-06-2300 /test area sign584/:
- short matrix test comparisons show changes in affected plots in DQM
- reco products monitored with fwlite script are not affected

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_5_X.

cleanup of uninitialized reads reported by valgrind (backport of #11173 )

It involves the following packages:

DQM/CSCMonitorModule
DQM/HcalMonitorTasks
DQM/Physics
DataFormats/JetReco
PhysicsTools/PatUtils
RecoEcal/EgammaCoreTools

@cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @danduggan can you please review it and eventually sign? Thanks.
@rappoccio, @Sam-Harper, @barvic, @imarches, @ahinzmann, @acaudron, @mmarionncern, @lgray, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @argiro, @pvmulder, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 322de3a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11175/7945/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11175/7945/summary.html

[slava77]

+1

#11175 322de3a

• jenkins tests pass and comparisons with the baseline are in agreement with local tests (diffs are only in a while-since randomly changing DQM plots)