Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port PR 11149 to 76X #11188

Closed
wants to merge 1 commit into from

Conversation

perrozzi
Copy link

@perrozzi perrozzi commented Sep 8, 2015

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

A new Pull Request was created by @perrozzi for CMSSW_7_6_X.

port PR 11149 to 76X

It involves the following packages:

GeneratorInterface/Core
GeneratorInterface/GenFilters

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bendavid
Copy link
Contributor

bendavid commented Sep 8, 2015

This has conflicts apparently.

@perrozzi
Copy link
Author

perrozzi commented Sep 8, 2015

yes, I am afraid because for a file it had to change >65% and so rewrote it.
is there a way to check what is causing the conflict?

@bendavid
Copy link
Contributor

bendavid commented Sep 8, 2015

Eh not sure, but the fact it rewrote a file should not itself be a problem.

Make sure you start from a recent IB rather than just a pre-release I guess.

@perrozzi perrozzi closed this Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants