Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy b-taggers from the standard reco #11198

Conversation

ferencek
Copy link
Contributor

@ferencek ferencek commented Sep 9, 2015

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_6_X.

Remove legacy b-taggers from the standard reco

It involves the following packages:

DQMOffline/RecoB
HLTriggerOffline/Higgs
PhysicsTools/PatAlgos
RecoBTag/Configuration

@cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @danduggan can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

label = cms.InputTag("combinedSecondaryVertexBJetTags"),
folder = cms.string("CSV_tkOnly")
),
#cms.PSet(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and in the rest of this PR, please remove the code, not comment it out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@slava77
Copy link
Contributor

slava77 commented Sep 10, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Sep 15, 2015

DQM is showing empty plots in the following folders

  • TopHLTOffline/Top/SemiMuoninc/step0
  • TopHLTOffline/Top/SemiMuoninc/step1
  • TopHLTOffline/Top/SemiMuoninc/step2
    I suppose these are symptoms of the same problem.

Things seem good on all other comparisons or technical values I have looked at.

@ferencek
Copy link
Contributor Author

OK, I found and fixed a typo in the tagger name in top HLT DQM. Hopefully all the remaining problems are now resolved.

@cmsbuild
Copy link
Contributor

Pull request #11198 was updated. @cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @danduggan can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Sep 15, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 15, 2015

+1

for #11198 8d171b5

  • code/config changes are OK, including planned removal of the legacy b-taggers and also removal of TagInfos from EI event content
  • jenkins tests pass and comparisons with baseline show expected changes
    • fwlite-based comparisons show "empty" plots corresponding to removed products
    • DQM/validation plots show some changes in b-tagging related distributions where the legacy taggers were replaced with the current pf candidate based taggers
  • tested locally in CMSSW_7_6_X_2015-09-07-2300 /test area sign589/ to check the technical performance and confirm jenkins tests on higher statistics
    • about 30 tagger producers are no longer running (reco+PAT workflow); this has low impact on total CPU and memory (40ms/event or ~0.3% of RECO)
    • in RECO/AOD one new tagging variable was added pfCombinedInclusiveSecondaryVertexV2BJetTagsEI and 21/16 legacy taggers were removed with a net effect of 1.4% reduction in AOD and 1% reduction of RECO size

@deguio
Copy link
Contributor

deguio commented Sep 16, 2015

+1

davidlange6 added a commit that referenced this pull request Sep 17, 2015
…CMSSW_7_6_0_pre4

Remove legacy b-taggers from the standard reco
@davidlange6 davidlange6 merged commit 3fd9c44 into cms-sw:CMSSW_7_6_X Sep 17, 2015
@ferencek ferencek deleted the RemoveLegacyBTaggers_from-CMSSW_7_6_0_pre4 branch September 17, 2015 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants