-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy b-taggers from the standard reco #11198
Remove legacy b-taggers from the standard reco #11198
Conversation
A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_6_X. Remove legacy b-taggers from the standard reco It involves the following packages: DQMOffline/RecoB @cvuosalo, @monttj, @cmsbuild, @deguio, @slava77, @vadler, @danduggan can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
label = cms.InputTag("combinedSecondaryVertexBJetTags"), | ||
folder = cms.string("CSV_tkOnly") | ||
), | ||
#cms.PSet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and in the rest of this PR, please remove the code, not comment it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
@cmsbuild please test |
The tests are being triggered in jenkins. |
DQM is showing empty plots in the following folders
Things seem good on all other comparisons or technical values I have looked at. |
OK, I found and fixed a typo in the tagger name in top HLT DQM. Hopefully all the remaining problems are now resolved. |
please test |
The tests are being triggered in jenkins. |
+1
|
+1 |
…CMSSW_7_6_0_pre4 Remove legacy b-taggers from the standard reco
No description provided.