add protection for rare infinite loop in ecal multifit (75X)

[bendavid]

backport of #11204 to 75x

[cmsbuild]

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_5_X.

add protection for rare infinite loop in ecal multifit (75X)

It involves the following packages:

RecoLocalCalo/EcalRecAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[slava77]

@cmsbuild please test

[slava77]

I started tests manually from the jenkins interface

[cmsbuild]

+1
Tested at: 15ca232
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11207/8006/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11207/8006/summary.html

[cvuosalo]

+1

For #11207 15ca232

Bug fix for rare infinite loop in ECAL multifit. There should be no change in monitored quantities. #11205 and #11204 are the 74X and 76X versions of this PR, and they have already been approved by Reco.

The fixed code is satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-09-09-2300 show no significant differences, as expected. The bug fix was verified for #11205.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1