Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLtriggerOffline/Higgs path update (75X) #11208

Conversation

jasperlauwers
Copy link
Contributor

Backport of #11206

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

A new Pull Request was created by @jasperlauwers for CMSSW_7_5_X.

HLtriggerOffline/Higgs path update (75X)

It involves the following packages:

HLTriggerOffline/Higgs

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 14, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 14, 2015

+1
provided it passes the tests

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@jasperlauwers
Copy link
Contributor Author

This has been merged in 76X 8 days ago and now is holding up other pull requests. Is there a reason why it didn't get merged yet?

@davidlange6
Copy link
Contributor

as commented in this thread, validation in 76x is needed (which can happen once 760pre6 is built and run throw relval cycle)

On Sep 23, 2015, at 3:50 PM, jasperlauwers [email protected] wrote:

This has been merged in 76X 8 days ago and now is holding up other pull requests. Is there a reason why it didn't get merged yet?


Reply to this email directly or view it on GitHub.

@jasperlauwers
Copy link
Contributor Author

Thanks for the explanation. The reason I am asking is because I was asked in #11342 to make a separate PR for adding a new path.
Do I understand correctly that the procedure to follow is to make a PR for that one commit separately and then rebase this one? And that the reason that #11342 doesn't need validation in 76x is because is doesn't make any changes to the code itself (although in this PR it are only two lines) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants