Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of PR #11213 (making space for storing "method 3" energy in HBHERecHit) #11214

Closed

Conversation

igv4321
Copy link
Contributor

@igv4321 igv4321 commented Sep 9, 2015

Backport of PR #11213 to 7_5_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

A new Pull Request was created by @igv4321 (Igor Volobouev) for CMSSW_7_5_X.

Backport of PR #11213

It involves the following packages:

DataFormats/HcalRecHit
RecoLocalCalo/HcalRecAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 9, 2015

@igv4321 please use a more verbose subject for the PR (e.g. "Preparing to include Method 3 result into HBHERecHit (backport of #11213)"

@cvuosalo
Copy link
Contributor

cvuosalo commented Sep 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 11, 2015

#11214 (comment)
""
@igv4321 please use a more verbose subject for the PR (e.g. "Preparing to include Method 3 result into HBHERecHit (backport of #11213)"
""
Thank you.

@slava77
Copy link
Contributor

slava77 commented Sep 11, 2015

+1

for #11214 9cae790

  • the same changes were applied here as in 76X PR
  • new code is not used anywhere yet; the change in the HCAL hit data format should be transparent in 75X with respect to other already generated samples (addition of a member)
  • jenkins tests pass and comparisons with baseline show no differences, as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@abdoulline
Copy link

May we get it merged for Igor to proceed with making Method 3 permanently running (as Method 0 does) ?

@davidlange6
Copy link
Contributor

@igv4321 @abdoulline - please add a description in the PR name for the release notes. Thanks

@igv4321 igv4321 changed the title Backport of PR #11213 Backport of PR #11213 (making space for storing "method 3" energy in HBHERecHit) Oct 22, 2015
@igv4321
Copy link
Contributor Author

igv4321 commented Oct 22, 2015

Done

@davidlange6
Copy link
Contributor

Hi - I'm cleaning up the 75x CMSSW release queue, so closing issues not directly related to analysis or finalizing the HI MC production. Please make sure these requests are included in the 80x release already. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants