-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exotica dqm updated histograms #11216
Exotica dqm updated histograms #11216
Conversation
… histograms, updated constrains in dijet and diphoton histograms to reduce background and added histograms to monitor dijet an wprime tails
A new Pull Request was created by @aescalante (Alberto Escalante del Valle) for CMSSW_7_4_X. Exotica dqm updated histograms It involves the following packages: DQM/Physics @cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
ciao @aescalante |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
…s_to76X PR #11216 in 7_4_X propagated to 7_6_X, Exotica DQM Updated histograms
+1 |
Exotica dqm updated histograms
it looks like the GT used by the Tier0 does not include the JEC needed by this PR. The AlCa team does not have the conditions needed, so for the moment, we will revert this PR. |
I can remove the JEC if needed to avoid this kind of problems. |
@aescalante
So, apart from the uncertainty, the same keys are available in both payloads. Am I missing something? @mmusich this is something you might want to watch as well |
Thanks for the help @diguida Yes I changed that because at some point I had some problems running locally in data and I thought that was problematic and the change was the solution, but it seems that the proposed change is problematic. So I can go back to the "old" configuration if its ok or I can also drop the JEC since Exotica is not validating the JEC and the validation can work without them. Alberto |
@aescalante |
@aescalante
for the reverted PRs you will need to resubmit them again with the fix on top. |
…atedHistograms_to76X Revert "PR #11216 in 7_4_X propagated to 7_6_X, Exotica DQM Updated h…
Hi all, finally how can we proceed with this PR?? Should I remove the JEC from the PR or change the way I get them (to the way I used to do it before)? Alberto. |
Updated charge cuts to deal with 0T conditions, updated range of some histograms, updated constrains in dijet and diphoton histograms to reduce background and added histograms to monitor dijet an wprime tails