-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HeavyIon: Add E/p cut to electrons and extend event content for electron collections. #11223
HeavyIon: Add E/p cut to electrons and extend event content for electron collections. #11223
Conversation
75X backport PR is #11224 |
A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_6_X. HeavyIon: Add E/p cut to electrons and extend event content for electron collections. It involves the following packages: RecoHI/Configuration @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 For Heavy Ions, adding E/p cut to electrons. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-09-2300 show no significant differences. An extended test with 70 events of workflow 140.53_RunHI2011 against baseline CMSSW_7_6_0_pre4 also shows no significant differences. CPU timing and product sizes also did not change significantly. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
HeavyIon: Add E/p cut to electrons and extend event content for electron collections.
HeavyIon: Add E/p cut to electrons and extend event content for electron collections. (75X backport of #11223)
This PR adds an E/p cut of <2 to the Heavy Ion electron reconstructions chain. The reason for this cut is to remove fake jets which arise from low-pt (very-curved) tracks attached to high pt ecal clusters. Theses "electrons" are then included in jets, but since the track is very curved the ecal cluster is not actually inside the jet.
Please see motivation slides here:
https://twiki.cern.ch/twiki/pub/CMS/PhotonAnalyses2015/20150825_fakerate.pdf
Additional documentation can be provided on request.
Additionally, this PR includes two additions to the Heavy Ion Event Content for electron-related quantities.
This PR should not affect pp workflows in any way.
Matrices 5.1 and 140.53 worked locally for me.
This will also be backported to 7_5_X.
This PR supersedes @doanhien PRs #11193 and #11191, both of those should be closed.