VID fix & core unit tests + Regression ValueMap Producer code cleanup. (75X)

[lgray]

Backport of #11229.

Closed #11230 since it was pointed at CMSSW_7_6_X, instead of 7_5_X.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

VID fix & core unit tests + Regression ValueMap Producer code cleanup. (75X)

It involves the following packages:

RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

@slava77 resubmitting tests using 75X as baseline release.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: bf0c53d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11231/8028/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11231/8028/summary.html

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

Pull request #11231 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: f381c77
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11231/8069/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11231/8069/summary.html

[slava77]

+1

for #11231 f381c77

• same code changes as in the 76X PR VID fix & core unit tests + Regression ValueMap Producer code cleanup. (76X) #11229 (except for the change in the input files used in the /test configurations)
  • mostly refactoring and addition of unit tests. there is also a bugfix in the regresion input variable computations
• plot from wflow 4.53 in jenkins shows the expected small change in the miniAOD electron kinematics
  

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[lgray]

@davidlange6 When can this one go in? It is blocking the 75X regression PR (backport of #11367).

[lgray]

@davidlange6 Anything blocking this going in since it is now running in T0 (in 74X)? Again needed for cutting 754 tomorrow.

[davidlange6]

+1

[lgray]

Thanks!

On Mon, Sep 21, 2015 at 9:13 PM, David Lange [email protected]
wrote:

+1

—
Reply to this email directly or view it on GitHub
#11231 (comment).