Update two variables of electron MVA to match the training definition (74X)

[lgray]

Backport of #11260.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_4_X.

Update two variables of electron MVA to match the training definition (74X)

It involves the following packages:

RecoEgamma/ElectronIdentification

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

@gpetruc

[lgray]

@ikrav FYI

[cmsbuild]

+1
Tested at: f6dc8e7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11262/8101/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11262/8101/summary.html

[slava77]

+1

for #11262 f6dc8e7

• the same change in variables used to compute ele ID variable in miniAOD as introduced in 75X and 76X (no changes in RECO part)
• jenkins tests pass and comparisons with baseline show no difference

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[lgray]

@davidlange6 Not merged into 74X somehow?

[lgray]

@davidlange6 Did this make it into 7_4_13? Why was it never merged?

[lgray]

@davidlange6 Nope... it did not make it into 7_4_13 despite being in 7_4_12 patches. Luckily we need a patch release anyway.

@gpetruc

[lgray]

@davidlange6 sorry, false alarm. Can't, in an easy way, tell that this PR is a noop due to different commit hash.

[lgray]

@davidlange6 Actually, I don't see any automatic merge or indication otherwise in ShowIB that 7_4_12_patchX was merged into the main 7_4_X. What's going on here?

[slava77]

On 9/28/15 3:56 PM, Lindsey Gray wrote:

@davidlange6 https://github.com/davidlange6 sorry, false alarm. Can't,
in an easy way, tell that this PR is a noop due to different commit hash.

Lindsey, would you mind checking merge of this and other PRs you think
are missing
and close them if they are no-ops
and if not, we should get an update.

—
Reply to this email directly or view it on GitHub
#11262 (comment).

[lgray]

@davidlange6 @slava77

CMSSW_7_4_13...cms-sw:CMSSW_7_4_12_patch4

As you can see there are some missing merges in 7_4_13... Unless this is part of some master plan?

[lgray]

@davidlange6 @slava77 @ikrav Correction - not merges but Ilya's fix (only) is missing from 7_4_13. Please fix.

[davidlange6]

@lgray - yes, seems I lost this one. the other two PRs are consistent between patchX and 7_4_13

[lgray]

@gpetruc @davidlange6 Just for completeness, ready to go here too.

[lgray]

@davidlange6 ping please include this one too

[davidlange6]

+1