CSC Beam Halo filter update #11266
CSC Beam Halo filter update #11266
Conversation
|
A new Pull Request was created by @lathomas for CMSSW_7_6_X. CSC Beam Halo filter update It involves the following packages: DataFormats/METReco @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 Copying tmp/slc6_amd64_gcc493/src/CondCore/Utilities/bin/conddb_test_gt_perf/conddb_test_gt_perf to productstore area: Copying tmp/slc6_amd64_gcc493/src/CondCore/Utilities/bin/cmscond_export_database/cmscond_export_database to productstore area: >> Building binary conddb_test >> Building binary conddb_import Copying tmp/slc6_amd64_gcc493/src/CondCore/Utilities/bin/cmscond_create_key/cmscond_create_key to productstore area: error: class 'reco::CSCHaloData' has a different checksum for ClassVersion 10. Increment ClassVersion to 11 and assign it to checksum 1723373351 >> Building binary cmscond_encode_db_file Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/METReco/src/classes_def.xml.generated with updated ClassVersion gmake: **\* [tmp/slc6_amd64_gcc493/src/DataFormats/METReco/src/DataFormatsMETReco/libDataFormatsMETRecoCapabilities.so] Error 1 >> Building binary conddb_copy_iov Copying tmp/slc6_amd64_gcc493/src/CondCore/Utilities/bin/cmscond_export_iov/cmscond_export_iov to productstore area: you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
I have updated the request last night with the proper classes_def.xml definition, so you can rerun the test whenever you want ! It should hopefully work this time. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| float jZ = jGlobalPosition.z() ; | ||
| float jT = jSegment->time(); | ||
| // if(abs(jZ)<650&& TheEvent.id().run() < 251737)jT-= 25; | ||
| if (TMath::ACos(TMath::Cos(jPhi - iPhi)) <= 0.2//max_segment_phi_diff |
There was a problem hiding this comment.
Looks like you missed one of the unnecessary ACos(Cos()) cases.
There was a problem hiding this comment.
Ah yes... I will correct this but I first would like to make sure the compilation tests are ok.
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
cmsbuild
added
comparison-available
tests-pending
comparison-pending
and removed
comparison-pending
comparison-available
tests-approved
labels
|
Pull request updated (replacing acos(cos()) by deltaphi() ) |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
+1 Small improvements to the CSC beam halo filter. #11136 and #11137 are the 74X and 75X versions of this PR, and they have already been approved by Reco. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-16-1200 show no significant differences. See #11136 for a performance summary that shows no significant change in timing with this PR. |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
pending-signatures
reconstruction-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
|
@davidlange6 Can you also merge the PR for 74 and 75? |
Hi,
This PR is a copy of the PR made for 74X and 75X:
#11136
#11137
-Pairs of segments in opposite endcaps are now matched with a dr/dz condition (rather than dr previously)
-The dphi condition to match segment has been tightened from 0.35 to 0.2.
-New flat CSC segment matching added (the old one remains the default for now): unvetoing CSC segments associated to tracker muons with pt < 3 gev
-Optional dt matching of opposite endcaps segments
-Testing a CSC segment/calorechit matching.
-Two new working points added in BeamHaloSummary.
The changes on the current filter only affect the counting of the flat segments, especially for opposite endcaps.
The current distribution of the two variables entering the current filter (longest chain of flat segments and opposite endcaps segments found) is shown on S15 here (left plots):
https://indico.cern.ch/event/438533/contribution/1/attachments/1139775/1632303/beamhalo.pdf
I have also added various methods to the CSCHaloData class. Two new filters were added to BeamHaloSummary but are not used anywhere so far. So all the changes, except the two mentioned above should not break anything and the size of the updated classes should not be dramatically modified.