-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't pass puppi NaNs to pseudojet methods #11267
don't pass puppi NaNs to pseudojet methods #11267
Conversation
A new Pull Request was created by @slava77 (Slava Krutelyov) for CMSSW_7_4_X. don't pass puppi NaNs to pseudojet methods It involves the following packages: CommonTools/PileupAlgos @cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
@slava77 - is is known why we have nans in the first place? |
…iner don't pass puppi NaNs to pseudojet methods
I can take a look. (I don't know)
|
…gn591/crashA-PuppiContainer don't pass puppi NaNs to pseudojet methods (port of #11267 to 75X)
+1 (just for the record that there are no diffs in jenkins tests, as expected) |
as for the origins: there is a follow up #11302, which still needs an extra look from Michalis |
…A-PuppiContainer don't pass puppi NaNs to pseudojet methods (port of #11267 to 76X)
fix crash reported in https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1385.html
[and likely similar ones observed with the previous versions in 0T in the past]
tested in CMSSW_7_4_12 with the setup reported in the HN: