Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method3 with hcal time slew update, backwards compatible #11274

Merged
merged 4 commits into from
Sep 16, 2015

Conversation

davidlange6
Copy link
Contributor

Picked up #11101
removed the empty customise functions to avoid merge conflicts
move changes in hcal time slew and method 3 scale into customise function as temporary solution while this is all being validated

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_5_X.

Method3 with hcal time slew update, backwards compatible

It involves the following packages:

CalibCalorimetry/HcalAlgos
HLTrigger/Configuration
RecoLocalCalo/HcalRecAlgos
RecoLocalCalo/HcalRecProducers
SLHCUpgradeSimulations/Configuration

@perrotta, @cmsbuild, @civanch, @diguida, @cvuosalo, @fwyzard, @mdhildreth, @Martin-Grunewald, @cerminar, @slava77, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel, @geoff-smith, @jalimena, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Sep 16, 2015
Method3 with hcal time slew update, backwards compatible
@davidlange6 davidlange6 merged commit ec222c7 into cms-sw:CMSSW_7_5_X Sep 16, 2015
@davidlt
Copy link
Contributor

davidlt commented Sep 17, 2015

This breaks Clang on 7_6_X, yet the fix is trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants