-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method3 with hcal time slew update, backwards compatible #11274
Conversation
…tion for data and MC
A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_5_X. Method3 with hcal time slew update, backwards compatible It involves the following packages: CalibCalorimetry/HcalAlgos @perrotta, @cmsbuild, @civanch, @diguida, @cvuosalo, @fwyzard, @mdhildreth, @Martin-Grunewald, @cerminar, @slava77, @mmusich can you please review it and eventually sign? Thanks. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Method3 with hcal time slew update, backwards compatible
This breaks Clang on 7_6_X, yet the fix is trivial. |
Picked up #11101
removed the empty customise functions to avoid merge conflicts
move changes in hcal time slew and method 3 scale into customise function as temporary solution while this is all being validated