Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sigmaietaiphi for photon regression inputs #11276

Merged
merged 1 commit into from
Sep 18, 2015

Conversation

fcouderc
Copy link
Contributor

adding the sigmaietaiphi variable which was missing to compute the photon regression
which affects the photon energy scale computation

@lgray
Copy link
Contributor

lgray commented Sep 16, 2015

@cmsbuild please test

@lgray
Copy link
Contributor

lgray commented Sep 16, 2015

@slava77 I'll cherry pick this commit into the ongoing PRs for 75X/74X. It seems to merge fine, so could be separate PR. Your preference.

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 16, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fcouderc for CMSSW_7_6_X.

add sigmaietaiphi for photon regression inputs

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 16, 2015

@cmsbuild please test
the last round went to 13-1100 IB, which is older than this PR.
Current tests are being done with CMSSW_7_6_X_2015-09-16-1200 already

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@lgray
Copy link
Contributor

lgray commented Sep 17, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 17, 2015

+1

for #11276 7ea1ba5

  • this is a clear bugfix; the fix affects correctedEnergy of pat photons if modifiers are running (there are no DQM miniAOD validation plots for photons, as far as I can see)
  • jenkins tests pass and comparisons with baseline show no differences (as expected)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 18, 2015
add sigmaietaiphi for photon regression inputs
@cmsbuild cmsbuild merged commit ff1295a into cms-sw:CMSSW_7_6_X Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants