-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding fastjet shape correction for analysis in 74x #11285
Adding fastjet shape correction for analysis in 74x #11285
Conversation
A new Pull Request was created by @rappoccio for CMSSW_7_4_X. Adding fastjet shape correction for analysis in 74x It involves the following packages: RecoJets/JetProducers @cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Please hold off on the tests, many apologies but the line "use_common_bge_for_rho_and_rhom" should be commented with the version of fastjet in the release. This will be in future fastjet versions. |
Apologies again... this is fixed. I accidentally committed my private version with private fastjet. |
@cmsbuild please test |
The tests are being triggered in jenkins. |
+1 Adding Fast Jet shape correction, but disabled by default. There should be no change in standard workflows. The shape correction is intended for expert use by analysts. The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_4_X_2015-09-16-1100 show no significant differences, as expected. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
Adding fastjet shape correction for analysis in 76x (port of #11285)
Adding fastjet shape correction for analysis in 75x (port of #11285)
+1 |
Adding fastjet shape correction for analysis in 74x
Here is a fastjet "rho-based" shape correction for future analysis releases in 74x.
Currently this is completely disabled by default. Some advances in fastjet contrib
are forthcoming to make this much faster than it currently is. Until then,
this should remain disabled except for expert usage in analyses.