-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove rct parameters hardcode from 74X #11288
remove rct parameters hardcode from 74X #11288
Conversation
A new Pull Request was created by @mulhearn for CMSSW_7_4_X. remove rct parameters hardcode from 74X It involves the following packages: L1Trigger/L1TCalorimeter @cmsbuild, @mulhearn can you please review it and eventually sign? Thanks. |
please test |
The tests are being triggered in jenkins. |
This has been in 75X and up for a long time. My mistake that it isn't in 74X. @davidlange6, any chance this can make 7_4_12_patch1? |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
patch1 needs a time machine- but I’ll add it to the list of items to go through.
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…code remove rct parameters hardcode from 74X
This should have been removed long ago... only noticing now because hard-coded values were in sync with latest tables in DB.