Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

75X 25ns HLT - round four #11294

Merged
merged 6 commits into from
Sep 17, 2015
Merged

75X 25ns HLT - round four #11294

merged 6 commits into from
Sep 17, 2015

Conversation

perrotta
Copy link
Contributor

Based on CMSSW_7_5_X_2015-09-16-1100

It includes (by now...) updates to the HLT menu up to /dev/CMSSW_7_4_0/HLT/V480

It also includes a fix that prevents FastSim crashing if the new menus integrated with #11042 are run

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Sep 16, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for CMSSW_7_5_X.

75X 25ns HLT - round four

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @geoff-smith, @jalimena this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@perrotta perrotta mentioned this pull request Sep 16, 2015
Merged
@perrotta
Copy link
Contributor Author

+1

@perrotta
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #11294 was updated. @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 209549b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11294/8145/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@perrotta
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

Pull request #11294 was updated. @cmsbuild can you please check and sign again.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

+1
Tested at: 866b850
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11294/8168/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
df67045
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11294/8168/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11294/8168/git-merge-result

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 17, 2015
@cmsbuild
Merge pull request #11294 from cms-tsg-storm/75X25nsHLTroundFour
152bf82 
75X 25ns HLT - round four
@cmsbuild cmsbuild merged commit 152bf82 into cms-sw:CMSSW_7_5_X Sep 17, 2015
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11294/8168/summary.html

@perrotta perrotta deleted the 75X25nsHLTroundFour branch September 17, 2015 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending fully-signed hlt-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_5_X
Development

Successfully merging this pull request may close these issues.
4 participants
@perrotta @cmsbuild @Martin-Grunewald @davidlange6