Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forward-port Premixing Validation modifications to 76X #11304

Merged
merged 12 commits into from
Sep 25, 2015
Merged

Forward-port Premixing Validation modifications to 76X #11304

merged 12 commits into from
Sep 25, 2015

Conversation

mdhildreth
Copy link
Contributor

simple forward port

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 17, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mdhildreth for CMSSW_7_6_X.

Forward-port Premixing Validation modifications to 76X

It involves the following packages:

Configuration/EventContent
Configuration/PyReleaseValidation
SimGeneral/DataMixingModule
SimMuon/MCTruth
SimTracker/TrackAssociatorProducers
SimTracker/TrackerHitAssociation
Validation/GlobalRecHits
Validation/RecoTrack
Validation/TrackerRecHits

@civanch, @danduggan, @boudoul, @franzoni, @mdhildreth, @cmsbuild, @srimanob, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @makortel, @threus, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @Martin-Grunewald, @istaslis, @rovere, @wmtford, @cerati, @trocino, @dgulhan, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mdhildreth
Copy link
Contributor Author

git cms-merge-topic and checkdeps show no conflicts. How do I find them? This is merged on top of 760_pre5

@civanch
Copy link
Contributor

civanch commented Sep 17, 2015

may be rebase even if files are the same?

mdhildreth and others added 12 commits September 18, 2015 04:34
@mdhildreth mdhildreth force-pushed the 76X_PreMixing_Validation_mods branch from a3e506a to 809b7cb Compare September 18, 2015 02:35
@mdhildreth
Copy link
Contributor Author

Rebased. Seems to have fixed whatever was wrong...

@mdhildreth
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

Pull request #11304 was updated. @danduggan, @boudoul, @srimanob, @cmsbuild, @franzoni, @deguio, @davidlange6 can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Sep 18, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 809b7cb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11304/8198/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11304/8198/summary.html

@deguio
Copy link
Contributor

deguio commented Sep 23, 2015

+1

davidlange6 added a commit that referenced this pull request Sep 25, 2015
@davidlange6
Merge pull request #11304 from mdhildreth/76X_PreMixing_Validation_mods
8c79907 
Forward-port Premixing Validation modifications to 76X
@davidlange6 davidlange6 merged commit 8c79907 into cms-sw:CMSSW_7_6_X Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available dqm-approved operations-pending orp-pending pdmv-pending pending-signatures simulation-approved tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.
6 participants
@mdhildreth @cmsbuild @civanch @deguio @davidlange6 @makortel